Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_db.py:97-98: Move test_db's product_id to generator.... #654

Open
0pdd opened this issue Dec 3, 2018 · 2 comments
Open

test_db.py:97-98: Move test_db's product_id to generator.... #654

0pdd opened this issue Dec 3, 2018 · 2 comments
Labels
3 we can defer this issue. But it'll good to implement it 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it

Comments

@0pdd
Copy link
Collaborator

0pdd commented Dec 3, 2018

The puzzle 645-c12aacc6 from #645 has to be resolved:

shopelectro/shopelectro/management/commands/test_db.py

Lines 97 to 98 in 4683e3b

# @todo #645:30m Move test_db's product_id to generator. stb2
# Now it uses dirty autoincrement.

The puzzle was created by duker33 on 03-Dec-18.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Dec 3, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Dec 3, 2018
@duker33
#645 Fix previews in load_more (#650)
4683e3b 
* #645  Create tests for load_more previews bug

* #645  Fix stale previews in load_more

* #645  Fix tests

* #645  Add comment about new not sliced list

* #645  Sync admin test to new fixtures

* #645  Fix comments according to linter
@0pdd 0pdd mentioned this issue Dec 3, 2018
Closed
@duker33 duker33 added 30 mins middle-sized issue. Usually a part of feature or a fix 3 we can defer this issue. But it'll good to implement it take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable labels Dec 7, 2018
@duker33
Copy link
Contributor

duker33 commented Jan 28, 2019

we used all free time for refactoring. We'll take this task later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 we can defer this issue. But it'll good to implement it 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd