Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#645 Fix previews in load_more #650

Merged
merged 6 commits into from Dec 3, 2018
Merged

#645 Fix previews in load_more #650

merged 6 commits into from Dec 3, 2018

Conversation

duker33
Copy link
Contributor

@duker33 duker33 commented Nov 30, 2018

Closes #645

@duker33 duker33 self-assigned this Nov 30, 2018
@duker33 duker33 changed the title #645 Fix load more #645 Fix image preview for load_more Nov 30, 2018
@duker33 duker33 changed the title #645 Fix image preview for load_more #645 Fix previews in load_more Nov 30, 2018
@@ -250,14 +250,19 @@ def load_more(request, category_slug, offset=0, limit=0, sorting=0, tags=None):
products = paginated_page.object_list
view = request.session.get('view_type', 'tile')

products_to_filter = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems products and products_to_filter are the same. How will exactly it help and what is the difference between them?

Copy link
Contributor Author

@duker33 duker33 Dec 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artemiy312 , products list has been sliced. That's why it can't be arg to context.
I'll append comment

@duker33 duker33 merged commit 4683e3b into master Dec 3, 2018
@duker33 duker33 deleted the 645_fix_load_more branch December 3, 2018 14:53
@duker33 duker33 restored the 645_fix_load_more branch December 3, 2018 14:53
@duker33 duker33 deleted the 645_fix_load_more branch December 3, 2018 14:53
@duker33 duker33 restored the 645_fix_load_more branch December 3, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants