Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grade to Django 1.11. stb2 #685

Closed
duker33 opened this issue Jan 5, 2019 · 3 comments
Closed

Grade to Django 1.11. stb2 #685

duker33 opened this issue Jan 5, 2019 · 3 comments
Assignees
@ArtemijRodionov
Labels
1 burning issue 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business

Comments

@duker33
Copy link
Contributor

duker33 commented Jan 5, 2019

Current 1.10 contains minor security issues
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour 1 burning issue labels Jan 5, 2019
@duker33 duker33 changed the title Grade to Django 1.11 Grade to Django 1.11. stb2 Jan 5, 2019
@ArtemijRodionov
Copy link
Contributor

Let's bump it to 1.11.17. This version should be used for python 3.7

@ArtemijRodionov ArtemijRodionov self-assigned this Jan 5, 2019
This was referenced Jan 5, 2019
Merged
Closed
@ArtemijRodionov
Copy link
Contributor

I have ran with sequence of inseparable issues when updating, so I'll increase the estimate, not split it

@ArtemijRodionov ArtemijRodionov added 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research cleanup everything that do project stronger, flexible, reusable and removed 1 hour typical issue size. It's one pdd hour labels Jan 5, 2019
@ArtemijRodionov
Copy link
Contributor

ArtemijRodionov commented Jan 5, 2019 •
edited
Loading

I have faced with these issues:

  • liveserver option is removed from django==1.11's manage.py
  • some form field structures is changed, without mentions this in release notes

This was referenced Jan 5, 2019
Closed
Merged
ArtemijRodionov added a commit that referenced this issue Jan 8, 2019
@ArtemijRodionov
#685 Grade django to 1.11.17 (#686)
eb3ef4d 
* Grade django to 1.11.17

* Remove --liveserver argument from tests. Create LIVESERVER_{PORT,HOST}.

* Remove LIVESERVER_PORT. Fix rendering of payment types.

* Trigger CI

* Finish with host address for selenium

* Self-review fixes
@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 burning issue 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @ArtemijRodionov