Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_selenium_mobile.py:138-140: Fix mobile selenium... #832

Closed
0pdd opened this issue Apr 30, 2019 · 1 comment · Fixed by #833
Closed

tests_selenium_mobile.py:138-140: Fix mobile selenium... #832

0pdd opened this issue Apr 30, 2019 · 1 comment · Fixed by #833
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue bug

Comments

@0pdd
Copy link
Collaborator

0pdd commented Apr 30, 2019

The puzzle 826-e15bd036 from #826 has to be resolved:

shopelectro/shopelectro/tests/tests_selenium_mobile.py

Lines 138 to 140 in 30b4966

# @todo #826:60m Fix mobile selenium driver. STB2
# The test shows, that the driver is broken.
# Probably we should properly setup desired capabilities of the driver.

The puzzle was created by Artemiy on 30-Apr-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Apr 30, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Apr 30, 2019
@ArtemijRodionov
#826 #830 collapse mobile tags (#831)
30b4966 
* Inverse collapse logic for mobile user agents. Fix collapse arrow indicator logic for tags.

* Test collapsed tags

* Create todo for selenium mobile driver

* Apply linter rules
@0pdd 0pdd mentioned this issue Apr 30, 2019
Closed
@ArtemijRodionov ArtemijRodionov self-assigned this Apr 30, 2019
@ArtemijRodionov ArtemijRodionov added 1 burning issue 1 hour typical issue size. It's one pdd hour bug labels Apr 30, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Apr 30, 2019
Merged
ArtemijRodionov added a commit that referenced this issue May 2, 2019
@ArtemijRodionov
#832 Fix mobile driver capabilities (#833)
53fa1d5 
* Fix mobile driver capabilities. Drop related todo. Add link to mobile emulation chrome guide

* Comment setting of window size for mobile test cases

* Apply linter rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#832 Fix mobile driver capabilities fidals/shopelectro
2 participants
@ArtemijRodionov @0pdd