Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_selenium_admin.py:146-149: Resurrect admin price... #835

Closed
0pdd opened this issue Apr 30, 2019 · 3 comments · Fixed by #848
Closed

tests_selenium_admin.py:146-149: Resurrect admin price... #835

0pdd opened this issue Apr 30, 2019 · 3 comments · Fixed by #848
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue bug

Comments

@0pdd
Copy link
Collaborator

0pdd commented Apr 30, 2019

The puzzle 822-138e7a1d from #822 has to be resolved:

shopelectro/shopelectro/tests/tests_selenium_admin.py

Lines 146 to 149 in c89b807

# @todo #822:30m Resurrect admin price filter.
# It's failing after fix changing `PriceRange.price_lookup` value.
# Fix was here: https://github.com/fidals/refarm-site/pull/325
# Just disable this filter for STB. It's not relevant there

The puzzle was created by duker33 on 30-Apr-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Apr 30, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Apr 30, 2019
@duker33
#822 Create categories matrix page (#829)
c89b807 
* #822  Draft for categories matrix

* #822  Markup for category matrix

* #fix  grade refarm version

* #822  Limit category matrix items

* #822  Subtask category matrix tests

* #822  Disable failed test and subtask filter resurrection

* #822  Subtask documenting category matrix functionality
@0pdd 0pdd mentioned this issue Apr 30, 2019
Closed
@ArtemijRodionov ArtemijRodionov self-assigned this May 1, 2019
@ArtemijRodionov ArtemijRodionov added 1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix bug labels May 1, 2019
@ArtemijRodionov
Copy link
Contributor

ArtemijRodionov commented May 16, 2019 •
edited

BTW drop price field from ProductAdminPage

@ArtemijRodionov ArtemijRodionov added 1 hour typical issue size. It's one pdd hour and removed 30 mins middle-sized issue. Usually a part of feature or a fix labels May 16, 2019
This was referenced May 16, 2019
Merged
Merged
ArtemijRodionov added a commit that referenced this issue May 17, 2019
@ArtemijRodionov
#835 admin price filter (#848)
b8929fe 
* Fix product price filter for admin panel

* Create few receipts for Makefile

* Fix typo in ProductPriceFilter

* Add price field to AdminProductPage

* Fix related tests
@0pdd 0pdd mentioned this issue May 17, 2019
Open
@0pdd
Copy link
Collaborator Author

0pdd commented May 17, 2019

@0pdd the puzzle #851 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#835 admin price filter fidals/shopelectro
2 participants
@ArtemijRodionov @0pdd