Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catalog.py:45-47: Improve categories matrix arch. Now... #880

Closed
0pdd opened this issue Jun 17, 2019 · 7 comments · Fixed by #925
Closed

catalog.py:45-47: Improve categories matrix arch. Now... #880

0pdd opened this issue Jun 17, 2019 · 7 comments · Fixed by #925
Assignees
@ArtemijRodionov
Labels
2 hours some big and monolith issue with hard decisions, discussions or bug with strong research 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable hard issue requires strong architecture skills, management skills, project domain area, etc

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jun 17, 2019

The puzzle 837-edb24a44 from #837 has to be resolved:

shopelectro/shopelectro/views/catalog.py

Lines 45 to 47 in bd9b654

# @todo #837:60m Improve categories matrix arch.
# Now it's untyped data structure with common comments.
# Turn it to the set of object with clear names.

The puzzle was created by duker33 on 17-Jun-19.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jun 17, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jun 17, 2019
@duker33
#837,855,871 Doc matrix, crumbs delimeter, name hint (#876)
bd9b654 
* #837  Doc matrix structure

* #837  Subtask mobile cart fix

* #855  Rm excess crumbs delimiter

* #871  Add hint to the product tile on category page

* #837  Fix crumbs count tests

* #855  Fix crumbs tests

* #837  Skip non-relevant test
This was referenced Jun 17, 2019
Closed
Closed
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour 2 performer can implement issue at his closest convenient time hard issue requires strong architecture skills, management skills, project domain area, etc take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable labels Jun 17, 2019
@ArtemijRodionov ArtemijRodionov self-assigned this Jun 24, 2019
@ArtemijRodionov ArtemijRodionov removed the take it any teammate can take this issue and start working with it label Jun 24, 2019
@0pdd 0pdd mentioned this issue Jul 2, 2019
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 2, 2019

@0pdd the puzzle #924 is still not solved.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 2, 2019

@0pdd the only puzzle #924 is solved here.

@ArtemijRodionov ArtemijRodionov mentioned this issue Jul 2, 2019
Merged
@duker33
Copy link
Contributor

duker33 commented Jul 2, 2019

may be it's related to fidals/stroyprombeton#631

@ArtemijRodionov ArtemijRodionov added 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research and removed 1 hour typical issue size. It's one pdd hour labels Jul 4, 2019
ArtemijRodionov added a commit that referenced this issue Jul 4, 2019
@ArtemijRodionov
#880 Create CatalogBlock model (#925)
6ed0777 
* Create CatalogBlock model and add sublime's configs to .gitignore

* Remove related todo

* Review fixes

* Rework MatrixBlock tests
This was referenced Jul 4, 2019
Closed
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 4, 2019

@0pdd 2 puzzles #934, #935 are still not solved; solved: #924.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 6, 2019

@0pdd the puzzle #942 is still not solved; solved: #924, #934, #935.

@0pdd
Copy link
Collaborator Author

0pdd commented Sep 24, 2019

@0pdd all 4 puzzles are solved here: #924, #934, #935, #942.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
2 hours some big and monolith issue with hard decisions, discussions or bug with strong research 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable hard issue requires strong architecture skills, management skills, project domain area, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#880 Create CatalogBlock model fidals/shopelectro
3 participants
@duker33 @ArtemijRodionov @0pdd