Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_selenium_mobile.py:161-162: Fix mobile cart. Now... #881

Closed
0pdd opened this issue Jun 17, 2019 · 1 comment · Fixed by #898
Closed

tests_selenium_mobile.py:161-162: Fix mobile cart. Now... #881

0pdd opened this issue Jun 17, 2019 · 1 comment · Fixed by #898
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue bug front markup or work with js

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jun 17, 2019

The puzzle 843-3cc08e76 from #843 has to be resolved:

shopelectro/shopelectro/tests/tests_selenium_mobile.py

Lines 161 to 162 in bd9b654

# @todo #843:60m Fix mobile cart.
# Now it's test fails

The puzzle was created by duker33 on 17-Jun-19.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jun 17, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jun 17, 2019
@duker33
#837,855,871 Doc matrix, crumbs delimeter, name hint (#876)
bd9b654 
* #837  Doc matrix structure

* #837  Subtask mobile cart fix

* #855  Rm excess crumbs delimiter

* #871  Add hint to the product tile on category page

* #837  Fix crumbs count tests

* #855  Fix crumbs tests

* #837  Skip non-relevant test
@0pdd 0pdd mentioned this issue Jun 17, 2019
Closed
@duker33 duker33 added 1 burning issue 1 hour typical issue size. It's one pdd hour bug front markup or work with js take it any teammate can take this issue and start working with it labels Jun 17, 2019
@ArtemijRodionov ArtemijRodionov self-assigned this Jun 24, 2019
@ArtemijRodionov ArtemijRodionov removed the take it any teammate can take this issue and start working with it label Jun 24, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Jun 24, 2019
Merged
ArtemijRodionov added a commit that referenced this issue Jun 26, 2019
@ArtemijRodionov
#881 fix mobile cart test (#898)
f1e58ec 
* Exclude metadata for TEST_EVN

* Unskip test_cart

* Apply linter rules
0pdd referenced this issue Jun 28, 2019
@ArtemijRodionov
#884 Drop eslint in favor of Coala's ESLintBear (#906)
33ae939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue bug front markup or work with js
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#881 fix mobile cart test fidals/shopelectro
3 participants
@duker33 @ArtemijRodionov @0pdd