Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

font-awesome.less:19-21: Fix UI issues to update... #962

Closed
0pdd opened this issue Sep 18, 2019 · 2 comments · Fixed by #963
Closed

font-awesome.less:19-21: Fix UI issues to update... #962

0pdd opened this issue Sep 18, 2019 · 2 comments · Fixed by #963
Assignees
@duker33
Labels
1 hour typical issue size. It's one pdd hour 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 18, 2019

The puzzle 894-8ab56e9d from #894 has to be resolved:

shopelectro/front/less/vendors/font-awesome.less

Lines 19 to 21 in edfb9f8

// @todo #894:60m Fix UI issues to update font-awesome.
// See failed selenium tests set for details:
// https://ci.fidals.com/fidals/shopelectro/1674/10

The puzzle was created by @duker33 on 18-Sep-19.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Sep 18, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Sep 18, 2019
@duker33
#894 Update font-awesome to the latest version (#959)
edfb9f8 
* #894  Update font-awesome to the latest version

* #894  Revert back font-awesome. Add pdd task to finish upgrade
@0pdd 0pdd mentioned this issue Sep 18, 2019
Closed
@duker33 duker33 self-assigned this Sep 18, 2019
@duker33 duker33 added 1 burning issue 1 hour typical issue size. It's one pdd hour cleanup everything that do project stronger, flexible, reusable 2 performer can implement issue at his closest convenient time and removed 1 burning issue labels Sep 18, 2019
@duker33
Copy link
Contributor

duker33 commented Sep 19, 2019

tests are working fine on the local. I'll push it to CI again

duker33 added a commit that referenced this issue Sep 19, 2019
@duker33
#962 Switch code to the latest font-awesome version
701cb71
@duker33 duker33 mentioned this issue Sep 19, 2019
Merged
duker33 added a commit that referenced this issue Sep 20, 2019
@duker33
#962 Trigger selenium tests
a642df6
duker33 added a commit that referenced this issue Sep 22, 2019
@duker33
#962 Switch code to the latest font-awesome version (#963)
0e6b9b9 
* #962  Switch code to the latest font-awesome version

* #962  Trigger selenium tests

* #926  Trigger build again

* #345  Add missed config value for tests

* #926  Return missed font-awesome symbol

* #fix  Style for page 404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
1 hour typical issue size. It's one pdd hour 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#962 Switch code to the latest font-awesome version fidals/shopelectro
2 participants
@duker33 @0pdd