Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#303 Docs for build system #436

Merged
merged 2 commits into from Jul 25, 2018
Merged

#303 Docs for build system #436

merged 2 commits into from Jul 25, 2018

Conversation

duker33
Copy link
Contributor

@duker33 duker33 commented Jul 21, 2018

Closes #303

We have clear configs. That's why we don't need many words

@duker33 duker33 self-assigned this Jul 21, 2018
ArtemijRodionov
ArtemijRodionov approved these changes Jul 22, 2018
View reviewed changes
CI.md Outdated
@@ -0,0 +1,24 @@
# Continuous integration
Выполняет две задачи:
- тестит систему для каждого pull request'a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

добавь пункт про линтеры

CI.md Outdated
- собирает систему для dev и prod после каждого пуша в мастер-ветку.

## Как устроен CI
CI делаем через drone. Синтаксис его конфига - надмножество docker-compose.yml.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

надмножество docker-compose.yml. -> надмножество конфигов docker-compose

Людям не знакомы с docker-compose будет ясней так. Решай

CI.md Outdated
Поэтому билдим npm

# Кэширование
У текущей билд-системы Докера есть проблемы с кэшированием,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Проблема была исключительно с pip install, докер не запускал эту ветку из-за того, что мы не версионировали refarm-site. На текущий момент этой проблемы скорее всего нет

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

оставлю TODO с просьбой проверить

README.md Outdated
@@ -127,6 +128,13 @@ make backup

N.B.: Некоторые данные (например, медиафайлы) могут иметь большой размер. На момент написания этой заметки, архив с медиафайлами Shopelectro весил ~4GB.

# Continuous integration
Выполняет две задачи:
- тестит систему для каждого pull requesta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не забудь добавь сюда пункт про линтеры, если решишься

README.md Outdated
- тестит систему для каждого pull requesta
- собирает систему для dev и prod после каждого пуша в мастер-ветку.

[Как устроен CI внутри](CI.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если этого файла нет и он намечается, то можно поставить todo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ээм, есть, он в этом PR

@duker33
Copy link
Contributor Author

duker33 commented Jul 22, 2018

fixed all comments

@duker33 duker33 added the refine issue already have resolving code, but code needs some fixes label Jul 22, 2018
@duker33 duker33 merged commit 380d159 into master Jul 25, 2018
@duker33 duker33 deleted the 303_docs_for_build branch July 25, 2018 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtemijRodionov ArtemijRodionov ArtemijRodionov approved these changes

Assignees

@duker33 duker33

Labels
refine issue already have resolving code, but code needs some fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@duker33 @ArtemijRodionov