#759 google ecommerce #760
Conversation
front/js/shared/tracking.es6
Outdated
| @@ -78,6 +67,44 @@ | |||
| }); | |||
| } | |||
|
|
|||
| // @todo #759:30m Move PublishedGATracker to a separate file. | |||
|
|
|||
| class PublishedGATracker { | |||
There was a problem hiding this comment.
provide doc plz why it's published, but not common GATracker
There was a problem hiding this comment.
publish is not the most good name for classes purpose. LimitedGATracher or SafeGATracker might be more good. Up to you
There was a problem hiding this comment.
I believe LoadedGATracker would be the best name
front/js/shared/tracking.es6
Outdated
| ga('require', 'ecommerce'); // Ignore ESLintBear (block-scoped-var) | ||
| const tracker = new GATracker(ga, 'ecommerce'); // Ignore ESLintBear (block-scoped-var) | ||
|
|
||
| tracker.purchase(productsData, txData); |
There was a problem hiding this comment.
hope data is consistent with gAnalytics api docs. Looks too simple and suspicious =)
There was a problem hiding this comment.
Data were consistent before, so what could be wrong?
front/js/shared/tracking.es6
Outdated
| this.published = false; | ||
| } | ||
|
|
||
| purchase(productsData, txData) { |
There was a problem hiding this comment.
maybe it's possible to add tests for ecommerce behaviour.
We are already testing Ya.Metrika at SE: shopelectro.tests.tests_selenium.YandexMetrika
There was a problem hiding this comment.
I will create todo for it
Closes #759