Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

Dockerfile:29-32: Add CMD command to nodejs/Dockerfile.... #245

Closed
0pdd opened this issue Jul 11, 2018 · 1 comment · Fixed by #247 or fidals/shopelectro#414
Closed

Dockerfile:29-32: Add CMD command to nodejs/Dockerfile.... #245

0pdd opened this issue Jul 11, 2018 · 1 comment · Fixed by #247 or fidals/shopelectro#414
Assignees
@ArtemijRodionov
Labels
2 performer can implement issue at his closest convenient time 15 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 11, 2018

The puzzle 236-a96a2aaa from #236 has to be resolved:

stroyprombeton/docker/images/node/Dockerfile

Lines 29 to 32 in 6b15134

# @todo #236:30m Add CMD command to nodejs/Dockerfile.
# CMD must call "gulp watch" or "gulp build" depending on the presence of
# frontend built files. A command example:
# bash -c "[ '$(ls -A /usr/app/src_front/front)' ] && gulp watch || gulp build"

The puzzle was created by Artemiy on 11-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 11, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jul 11, 2018
@ArtemijRodionov
fidals/shopelectro#392 static files forwarding (#241)
6b15134 
* Create a todo to remove app's dependecy

* Review fixes
@0pdd 0pdd mentioned this issue Jul 11, 2018
Closed
@ArtemijRodionov ArtemijRodionov added 30 mins small issues. Usually cosmetic fixes 15 mins small issues. Usually cosmetic fixes 2 hours some big and monolith issues. For example with hard decisions or discussions 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable and removed 30 mins small issues. Usually cosmetic fixes 2 hours some big and monolith issues. For example with hard decisions or discussions labels Jul 11, 2018
@ArtemijRodionov ArtemijRodionov self-assigned this Jul 12, 2018
This was referenced Jul 12, 2018
Merged
Merged
ArtemijRodionov added a commit that referenced this issue Jul 13, 2018
@ArtemijRodionov
#245 #246 Remove the app service's depedency from a nodejs service. (#…
f80699c 
…247)

* Remove $FRONT_BUILD_DIR var. Mount built static files to host system

* Fix CI's npm stage. Implement CMD for nodejs Dockerfile.

* Uncomment CI's pipelines

* Fix CI's test pipe

* Review fixes

* Apply coala rules
@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Jul 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
2 performer can implement issue at his closest convenient time 15 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
2 participants
@ArtemijRodionov @0pdd