Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

tests_views.py:210-211: Take CatalogTags tests from SE.... #340

Closed
0pdd opened this issue Nov 17, 2018 · 3 comments
Closed

tests_views.py:210-211: Take CatalogTags tests from SE.... #340

0pdd opened this issue Nov 17, 2018 · 3 comments
Assignees
@duker33
Labels
1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable Tags feature

Comments

@0pdd
Copy link
Collaborator

0pdd commented Nov 17, 2018

The puzzle 320-eb49c2d0 from #320 has to be resolved:

stroyprombeton/stroyprombeton/tests/tests_views.py

Lines 210 to 211 in dec56f7

# @todo #320:60m Take CatalogTags tests from SE.
# `shopelectro.tests.tests_views.CatalogTags`

The puzzle was created by duker33 on 17-Nov-18.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Nov 17, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Nov 17, 2018
@duker33
#320 Tag tests (#337)
dec56f7 
* #320  Take tag tests from SE

* #320  Create products without tags at fixtures

* #320  Create views test for tags backend

* #320  Take tags selenium tests from SE

* #320  Fix failed load_more test

* #320  Fix failed tests. Minor review fixes

* #320  Fix failed tests

* #320  Fix failed tests #2

* #320  Ignore temporary code doubling

* #320  Comment back refarm site mapping
This was referenced Nov 17, 2018
Closed
Closed
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 2 performer can implement issue at his closest convenient time take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable Tags feature labels Nov 20, 2018
@duker33 duker33 self-assigned this Dec 20, 2018
@duker33 duker33 removed the take it any teammate can take this issue and start working with it label Dec 20, 2018
@duker33
Copy link
Contributor

duker33 commented Dec 20, 2018

stb already has stroyprombeton.tests.tests_views.CatalogTags tests set.
I'll refactor tests location, rm some doubling code and check if stb test semantic as full as se's one

duker33 added a commit that referenced this issue Dec 20, 2018
@duker33
#340 Rm code doubling with BaseCatalogTestCase class
c28d693
duker33 added a commit that referenced this issue Dec 20, 2018
@duker33
#340 Create selenium test for products count
b11fcaf
This was referenced Dec 20, 2018
Merged
Merged
duker33 added a commit that referenced this issue Dec 25, 2018
@duker33
#340 Improve Tags tests (#387)
b3f0fcb 
* #340  Rm code doubling with BaseCatalogTestCase class

* #340  Create selenium test for products count
0pdd referenced this issue Jan 25, 2019
@duker33
#fix Skip selenium test (#402)
4a4a837
@0pdd 0pdd mentioned this issue Jan 25, 2019
Open
@0pdd
Copy link
Collaborator Author

0pdd commented Jan 25, 2019

@0pdd the puzzle #406 is still not solved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@duker33 duker33

Labels
1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable Tags feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd