This repository has been archived by the owner on Feb 23, 2020. It is now read-only.
#320 Tag tests #337
Merged
#320 Tag tests #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemijRodionov
suggested changes
Nov 15, 2018
| @@ -214,9 +214,13 @@ def create_products(count, categories, tags_): | |||
| for tag in tags_: | |||
| product.tags.add(tag) | |||
|
|
|||
| # group together tags from different tag_groups | |||
There was a problem hiding this comment.
The comment below will be enough. Decide
| create_products(count=25, categories=parents[4:], tags_=zipped_tags[0]) | ||
| create_products(count=25, categories=parents[5:], tags_=zipped_tags[0]) | ||
| # some products should not contain any tag | ||
| create_products(count=25, categories=parents[4:4], tags_=[]) |
There was a problem hiding this comment.
Suggested change
| create_products(count=25, categories=parents[4:4], tags_=[]) | |
| create_products(count=25, categories=parents[4:5], tags_=[]) |
[4:4] produces an empty list
|
|
||
| from pages.models import Page | ||
|
|
||
| from stroyprombeton.models import Category, Product | ||
| # @todo #320:15m - Do the whole `models` import in tests_selenium |
There was a problem hiding this comment.
Import the stroyprombeton.models package as stb_models for the whole project.
There was a problem hiding this comment.
@artemiy312 , it's too long. I suggest this:
Import 'models' to it's own var
| sorting: int=None, | ||
| query_string: dict=None, | ||
| ) -> str: | ||
| from urllib.parse import urlencode |
There was a problem hiding this comment.
Move an import to the top
stroyprombeton/tests/tests_views.py
Outdated
| @@ -195,6 +207,25 @@ def test_inactive_product_not_in_category(self): | |||
| response = self.client.get(reverse('category', args=(test_product.category_id,))) | |||
| self.assertNotIn(test_product, response.context['products']) | |||
|
|
|||
| # @todo #320:60m Take from SE CatalogTags tests | |||
There was a problem hiding this comment.
What should we take?
duker33
force-pushed
the
320_tag_tests
branch
from
8b2d403
to
75cbe72
Compare
ArtemijRodionov
approved these changes
Nov 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #320