Skip to content

Commit

Permalink
linted. attempting to bust the actions cache since I can't replicate …
Browse files Browse the repository at this point in the history
…the 3.6 tests failing locally in a venv
  • Loading branch information
ncilfone committed Mar 11, 2022
1 parent d5879a6 commit 4b916fc
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/python-pytest-s3.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.6, 3.7, 3.8, 3.9, '3.10']
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10"]

steps:
- uses: actions/checkout@v2
Expand All @@ -26,7 +26,7 @@ jobs:
- uses: actions/cache@v2
with:
path: ${{ env.pythonLocation }}
key: ${{ env.pythonLocation }}-${{ hashFiles('setup.py') }}-${{ hashFiles('REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/DEV_REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/S3_REQUIREMENTS.txt') }}
key: cache-v1-${{ env.pythonLocation }}-${{ hashFiles('setup.py') }}-${{ hashFiles('REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/DEV_REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/S3_REQUIREMENTS.txt') }}

- name: Install dependencies
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/python-pytest-tune.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.7, 3.8, 3.9, '3.10']
python-version: ["3.7", "3.8", "3.9", "3.10"]

steps:
- uses: actions/checkout@v2
Expand All @@ -26,7 +26,7 @@ jobs:
- uses: actions/cache@v2
with:
path: ${{ env.pythonLocation }}
key: ${{ env.pythonLocation }}-${{ hashFiles('setup.py') }}-${{ hashFiles('REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/DEV_REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/S3_REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/TUNE_REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/TEST_EXTRAS_REQUIREMENTS_REQUIREMENTS.txt') }}
key: cache-v1-${{ env.pythonLocation }}-${{ hashFiles('setup.py') }}-${{ hashFiles('REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/DEV_REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/S3_REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/TUNE_REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/TEST_EXTRAS_REQUIREMENTS_REQUIREMENTS.txt') }}

- name: Install dependencies
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/python-pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.6, 3.7, 3.8, 3.9, '3.10']
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10"]

steps:
- uses: actions/checkout@v2
Expand All @@ -26,7 +26,7 @@ jobs:
- uses: actions/cache@v2
with:
path: ${{ env.pythonLocation }}
key: ${{ env.pythonLocation }}-${{ hashFiles('setup.py') }}-${{ hashFiles('REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/DEV_REQUIREMENTS.txt') }}
key: cache-v1-${{ env.pythonLocation }}-${{ hashFiles('setup.py') }}-${{ hashFiles('REQUIREMENTS.txt') }}-${{ hashFiles('./requirements/DEV_REQUIREMENTS.txt') }}

- name: Install dependencies
run: |
Expand Down
4 changes: 1 addition & 3 deletions spock/backend/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@
from spock.backend.spaces import BuilderSpace
from spock.backend.wrappers import Spockspace
from spock.graph import Graph
from spock.utils import make_argument

from spock.utils import _SpockVariadicGenericAlias
from spock.utils import _SpockVariadicGenericAlias, make_argument


class BaseBuilder(ABC): # pylint: disable=too-few-public-methods
Expand Down
7 changes: 6 additions & 1 deletion spock/backend/field_handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@
_SpockNotOptionalError,
_SpockValueError,
)
from spock.utils import _check_iterable, _is_spock_instance, _is_spock_tune_instance, _SpockVariadicGenericAlias
from spock.utils import (
_check_iterable,
_is_spock_instance,
_is_spock_tune_instance,
_SpockVariadicGenericAlias,
)


class RegisterFieldTemplate(ABC):
Expand Down
3 changes: 2 additions & 1 deletion spock/backend/typed.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@
from enum import Enum, EnumMeta
from functools import partial
from typing import TypeVar, Union
from spock.utils import _SpockGenericAlias, _SpockVariadicGenericAlias

import attr

from spock.utils import _SpockGenericAlias, _SpockVariadicGenericAlias


class SavePath(str):
"""Spock special key for saving the Spock config to file
Expand Down
4 changes: 3 additions & 1 deletion spock/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ def _get_callable_type():
elif minor > 8:
from typing import _CallableType as _VariadicGenericAlias
else:
raise RuntimeError(f"Attempting to use spock with python version `3.{minor}` which is unsupported")
raise RuntimeError(
f"Attempting to use spock with python version `3.{minor}` which is unsupported"
)
return _VariadicGenericAlias


Expand Down

0 comments on commit 4b916fc

Please sign in to comment.