Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes for v3.0.0 #273

Merged
merged 5 commits into from Jan 19, 2023
Merged

Bug Fixes for v3.0.0 #273

merged 5 commits into from Jan 19, 2023

Conversation

ncilfone
Copy link
Contributor

What does this PR do?

  • Fixes bug in the new resolver when there is both a cls and self variable reference -- casts were per type but needed to be one cast post all reference resolution
  • Fixed bug in new types (file and directory) for relative paths -- pathlib needs to call .resolve() prior to using the path
  • Added a helper methods module -- moved the to_dict method out of the SpockBuilder and into helpers so it can be independent of having an instantiated SpockBuilder

Checklist

  • Did you adhere to PEP-8 standards?
  • Did you run black and isort prior to submitting your PR?
  • [xx] Does your PR pass all existing unit tests?
  • Did you add associated unit tests for any additional functionality?
  • Did you provide code documentation (Google Docstring format) whenever possible, even for simple functions or classes?
  • Did you add necessary documentation to the website?

…ast was being called in both instead of after resolution before instantiation. Added unit test to capture behavior
…hs correctly. needed to use pathlib resolve before checking existence.
…of the SpockBulder object -- lol forgoat to add file
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3958892498

  • 36 of 36 (100.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 95.164%

Files with Coverage Reduction New Missed Lines %
spock/backend/resolvers.py 1 95.65%
Totals Coverage Status
Change from base Build 3939930346: 0.1%
Covered Lines: 2519
Relevant Lines: 2647

💛 - Coveralls

@mmalouane mmalouane merged commit af305f4 into fidelity:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants