Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds __map__ functionality #279

Merged
merged 16 commits into from
Nov 3, 2023
Merged

Adds __map__ functionality #279

merged 16 commits into from
Nov 3, 2023

Conversation

ncilfone
Copy link
Contributor

@ncilfone ncilfone commented Mar 6, 2023

What does this PR do?

Adds map functionality as another post instantiation hook option. This allows you to directly map spock configs to object creation etc. automatically upon creation. Additional docs and tests

Checklist

  • Did you adhere to PEP-8 standards?
  • Did you run black and isort prior to submitting your PR?
  • Does your PR pass all existing unit tests?
  • Did you add associated unit tests for any additional functionality?
  • Did you provide code documentation (Google Docstring format) whenever possible, even for simple functions or classes?
  • Did you add necessary documentation to the website?

@ncilfone
Copy link
Contributor Author

ncilfone commented Nov 3, 2023

Merged in fix for #296 - fixed tests to remove the r+w check since default is now changed to not check privs

@ncilfone
Copy link
Contributor Author

ncilfone commented Nov 3, 2023

@mmalouane This is the new PR that will cover #296 as well. Can you review and merge and release to help unblock this: #297 (comment)

@ncilfone ncilfone mentioned this pull request Nov 3, 2023
6 tasks
@coveralls
Copy link

coveralls commented Nov 3, 2023

Pull Request Test Coverage Report for Build 6746688429

  • 57 of 57 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 99.379%

Totals Coverage Status
Change from base Build 6746625954: 0.006%
Covered Lines: 3520
Relevant Lines: 3542

💛 - Coveralls

@ncilfone
Copy link
Contributor Author

ncilfone commented Nov 3, 2023

@mmalouane Ignore the failing build on 3.6 since we are deprecating support -- I think that one is stuck somehow. You should be able to force the merge as along as all the other tests pass

@mmalouane mmalouane merged commit 2e40d04 into fidelity:master Nov 3, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants