Issue #296 #297
Merged
Issue #296 #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to windows system needing stdin even as a null device. Other fix seems like it could be leaky resources from GitPython for long running processes. Make sure to call close() to help prevent resource leak. Also bump all the github actions ubuntu verion to 20.04 since 18.04 got deprecated
…ralls python dep and switching to the GHA for pushing coverage results to coveralls.io
|
@mmalouane Can you merge this and cut a new release with a minor version bump (3.1.0) -- handling python 3.6 deps and pyyaml specifically are breaking installs currently on 3.10 |
mmalouane
approved these changes
Oct 30, 2023
Signed-off-by: Mahdi Alouane <43279493+mmalouane@users.noreply.github.com>
|
Is there any update on when this build (3.6) expectation can be removed? We're currently blocked from using any python 3.10 images in AWS SageMaker until we get an updated version of spock |
|
@thomaselee See #279 that now merges the fix to #296 into some other functionality. Trying to get @mmalouane to approve and release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Attempting to fix #296. Seems like the general SO info points to windows system needing stdin even as a null device. Other fix seems like it could be leaky resources from GitPython for long running processes. Make sure to call close() to help prevent resource leak. Also bump all the github actions ubuntu version to 20.04 since 18.04 got deprecated
Checklist