forked from claudiok/clsim
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
hole ice: do not cut off
entry_point_ratio
and `termination_point_r…
…atio` if they are outside [0;1]. Previously, the ratios have been set to `nan` not only if no intersection point existed, but also if the intersection point is before or after the interaction points A, B. Now, that there are several unit tests in place, the `nan` values are no longer needed to catch algorithmic errors. Also, using `not_between_zero_and_one(a)` rather than `my_is_nan(a)` does simplify the hole ice algorithm in several places. The motivation behind this change is fiedl/hole-ice-study#2: I need the `termination_point_ratio` for calculations in new geometric cases „2b“ and „3b“. Therefore, the `termination_point_ratio` must not be cut off (set `nan`).
- Loading branch information
Showing
1 changed file
with
47 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters