Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH - docu fix and added nearest to private to keep preproc standalone #1637

Merged
merged 1 commit into from
Jan 14, 2021
Merged

ENH - docu fix and added nearest to private to keep preproc standalone #1637

merged 1 commit into from
Jan 14, 2021

Conversation

schoffelen
Copy link
Contributor

No description provided.

This was linked to issues Jan 14, 2021
Mismatch in documentation and code in ft_preproc_dftfilter.m prevents spectrum interpolation #1634
Closed
Matlab error occurs in call to ft_preproc_dftfilter.m, at line 176, nearest(), spectrum interpolation #1636
Closed
@schoffelen
Copy link
Contributor Author

This PR addresses two issues:

  • a typo in the documentation, causing confusion with respect to the correct naming of the input key-value arguments, which might have led to unexpected behavior if this documentation was literally followed, as per the original contribution of @sabineleske @sarangnemo
  • added nearest to the private folder of the preproc module, to avoid issues with overloaded matlab function if users do not have fieldtrip/utilities on their path

@schoffelen schoffelen merged commit 7f71464 into fieldtrip:master Jan 14, 2021
@schoffelen schoffelen deleted the dftfilter_docu branch January 14, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertoostenveld robertoostenveld Awaiting requested review from robertoostenveld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@schoffelen