networkanalysis: use parfor instead of for #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some small adaptations, it is possible to use a parfor loop in ft_networkanalysis. This potentially speeds up the calculation, when the parallel computing toolbox is available. Possibly, this could be further sped up by converting the nested loops into a single parfor loop. However, this requires a good benchmark testcase to be available, to test the difference.
Setting this limit to 0 will make the execution non-parallel
When input has only two dimensions, outsiz(4) did not exist. Calling size(input, 4) on a 2D input returns 1. Fix so outsiz, and new inputsize variable, always have 4 entries.
AljenU
force-pushed
the
parfor_networkanalysis
branch
from
48a19b9
to
f9e7358
Compare
robertoostenveld
moved this from In progress
to Done
in FieldTrip performance improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some small adaptations, it is possible to use a parfor loop in
ft_networkanalysis. This potentially speeds up the calculation, when the
parallel computing toolbox is available.
Possibly, this could be further sped up by converting the nested loops into
a single parfor loop. However, this requires a good benchmark testcase to be
available, to test the difference.
Tested with https://github.com/AljenU/fieldtrip-parallel-support/tree/additional_tests, however no tests were found that take more than a few seconds on ft_networkanalysis, making it hard to actually compare performance.
Output has been tested by comparing the saved output of ft_bench_04_networkanalysis_01.