Merge pull request #11 from zzgab/feature_xmlnsfig

resolves #10
figdice · Nov 28, 2016 · 5a884cd · 5a884cd
2 parents f04d9f0 + 9077b42
commit 5a884cd
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/figdice/View.php b/src/figdice/View.php
@@ -542,6 +542,10 @@ private function openTagHandler($xmlParser, $tagName, $attributes) {
 					break;
 				}
 			}
+
+			// Remove the fig xmlns directive from the list of attributes of the opening root tag
+      // (as it should not be rendered)
+      unset($attributes['xmlns:' . substr($this->figNamespace, 0, strlen($this->figNamespace) - 1)]);
 		}
 
 		$lineNumber = xml_get_current_line_number($xmlParser);

diff --git a/test/FigXmlTest.php b/test/FigXmlTest.php
@@ -434,6 +434,22 @@ public function testNestedLoops()
     $this->assertEquals('10-0 10-1 10-2 20-0 20-1 20-2 30-0 30-1 30-2 40-0 40-1 40-2 50-0 50-1 50-2', $result);
   }
 
+
+  public function testXmlnsFigIsNotRendered()
+  {
+    $template = <<<ENDTEMPLATE
+<html xmlns:fig="http://figdice.org/">
+</html>
+ENDTEMPLATE;
+
+    $view = new View();
+    $view->loadString($template);
+    $actual = $view->render();
+
+    $expected = "<html>\n</html>";
+    $this->assertEquals($expected, $actual);
+  }
+
 }