Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

closing over old state #2

Merged
merged 1 commit into from
Jul 12, 2017
Merged

closing over old state #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/enlarge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
toggleImgSrc();
}

if( o.disabled && zoomed ) {
if( o.disabled && $element.data("zoomed") ) {
standardToggleZoom();
}
});
Expand All @@ -159,7 +159,7 @@

// zoom state toggle boolean
function toggleZoomState(){
zoomed = !zoomed;
zoomed = !$element.data("zoomed");
$element.data("zoomed", zoomed);
}

Expand Down Expand Up @@ -227,7 +227,7 @@

// toggle magnification of image
function toggleImgZoom(){
if( zoomed ){
if( $element.data("zoomed") ){
// NOTE we allow the image to zoom out if functionality gets disabled
// when it's in a zoomed state
if(o.disabled) { return false; }
Expand Down Expand Up @@ -268,8 +268,7 @@
// lock zoom mode toggle
function standardToggleZoom(){
// NOTE if the current is zoomed out and it's disabled prevent toggling
if(o.disabled && !zoomed) { return false; }

if(o.disabled && !$element.data("zoomed")) { return false; }
toggleZoomState();
toggleImgSrc();
toggleImgZoom();
Expand Down