This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
85 #90
Merged
85 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: update functional test demos to use before, since it's recommended Remove deprecated callback argument fixes #76 Create import.html Remove moot `version` property from bower.json
…lesheet or script in the page if qsa is supported. Otherwise it inserts after the last script. In either case, the insertBefore is performed in the reference element's nextSibling, which serves as an "insertAfter" regardless of whether the reference element has a nextSibling or not. Despite the default behavior change, we've preserved the behavior of the "before" argument, if provided, so that the link is still inserted before that specific element in that case. We may want to standardize on inserting "after" in a later release. Fixes #85.
|
This looks beautiful, including the description and plan. Cheers! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our default insert behavior to insert after the last stylesheet or script in the page if qsa is supported. Otherwise it inserts after the last script. In either case, the insertBefore is performed in the reference element's nextSibling, which serves as an "insertAfter" regardless of whether the reference element has a nextSibling or not (news to me! Verified in IE6+).
Despite the default behavior change, we've preserved the behavior of the "before" argument, if provided, so that the link is still inserted before that specific element in that case. We may want to standardize on inserting "after" in a later release. Fixes #85.