Make commands lazy #12048
Make commands lazy #12048
Conversation
|
|
||
| #[AsCommand(name: 'make:filament-exporter', aliases: ['filament:exporter'])] |
There was a problem hiding this comment.
For the alias command classes, do the arguments need to be swapped? So make:filament-exporter is an alias of filament:exporter? Maybe I am understanding it wrong, but Symfony's docs do not explain this
There was a problem hiding this comment.
Maybe we dont need aliases: at all yet since we aren't using the $aliases property on the commands? These could be treated as separate commands where the alias classes just reference their own name?
Then we refactor to $aliases and get rid of these classes in v4
There was a problem hiding this comment.
Yes, I think we should treat these alias as separate command. I will go ahead and do that.
There was a problem hiding this comment.
For the alias command classes, do the arguments need to be swapped? So
make:filament-exporteris an alias offilament:exporter? Maybe I am understanding it wrong, but Symfony's docs do not explain this
For swapping of the arguments, I don't think so but I will test it out and see where that leads me.
| placeholder: 'Products/ListProducts', | ||
| required: true, | ||
| )) | ||
| $component = (string) str( |
There was a problem hiding this comment.
Please remove all formatting changes in this file and also MakeWidgetCommand
There was a problem hiding this comment.
Could this formatting be as a result of composer cs command or maybe from my IDE formatting.
stephenjude
force-pushed
the
fix/make-commands-lazy
branch
from
28341f9
to
24b9295
Compare
stephenjude
force-pushed
the
fix/make-commands-lazy
branch
from
24b9295
to
3780419
Compare
|
@danharrin I have made all necessary changes and rebased the commits into one. I think this PR is ready. Let me know if there anything else that needs my attention. |
Description
This PR makes the Filament commands "lazy", i.e., they do not need to be instantiated when running other commands.
Currently, when you have Filament installed in a Laravel project, if you were to run php artisan
filament:installall of the Filament commands are instantiated. This is just how Symfony console commands work.The
AsCommandattribute was introduced to allow commands to be "lazy", i.e., they do not need to be instantiated when running other commands.@timacdonald has been doing some work across the Laravel ecosystem to standardise this and I thought to drop by here and do the same.
See: laravel/framework#50617
Functional changes
composer cscommand.