-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with page scroll up to the top after change value of any Fields or Create,Save button Inside Tab Component. #6692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elds inside (TAB).
PR Summary
|
ibrahimBougaoua
changed the title
Fix issue with page scroll up to the top after change value of any fi…
Fix issue with page scroll up to the top after change value of any Fields or Create,Save button Inside Tab.
Jun 5, 2023
ibrahimBougaoua
changed the title
Fix issue with page scroll up to the top after change value of any Fields or Create,Save button Inside Tab.
Fix issue with page scroll up to the top after change value of any Fields or Create,Save button Inside Tab Component.
Jun 5, 2023
zepfietje
requested changes
Jun 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mark as ready for review when done!
Thanks |
The following issue also occurs on the wizard component of the filamentphp project by adding wire:ignore.self to wizard.blade.php this issue can be resolved for it as well. @danharrin |
Can you PR it then? |
yes i will add a PR. |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issuse appear when i use tab.
( Select Field,Create,Save,... ) whene changing or editing any data in the input field the page view goes up to the start of the page . i want to prevent the page view from changing after changing the data entry on the input field.
Solution : I added wire:ignore.self to the parent div of tab component,becouse wire:ignore.self only ignores the DOM element it is attached to,and all children element and fields work perfectly.