Skip to content

fixed scroll issue on wizard component#7490

Merged
danharrin merged 2 commits into
filamentphp:2.xfrom
rafayrty:fix/fixing-scroll-issue-on-wizard
Aug 6, 2023
Merged

fixed scroll issue on wizard component#7490
danharrin merged 2 commits into
filamentphp:2.xfrom
rafayrty:fix/fixing-scroll-issue-on-wizard

Conversation

@rafayrty
Copy link
Copy Markdown
Contributor

@rafayrty rafayrty commented Aug 5, 2023

  • Changes have been thoroughly tested to not break existing functionality.
  • New functionality has been documented or existing documentation has been updated to reflect changes.
  • Visual changes are explained in the PR description using a screenshot/recording of before and after.

@what-the-diff
Copy link
Copy Markdown
Contributor

what-the-diff Bot commented Aug 5, 2023

PR Summary

  • Enhancement to the Wizard Component
    The wizard component, part of our forms, has been improved. This has been achieved through the addition of a new directive (instruction) called wire:ignore.self in its code file (wizard.blade.php). This update would make the wizard component more reliable and efficient.

@rafayrty rafayrty closed this Aug 5, 2023
@rafayrty rafayrty reopened this Aug 5, 2023
@rafayrty
Copy link
Copy Markdown
Contributor Author

rafayrty commented Aug 5, 2023

The code has been updated on wizard.blade.php file to fix scrolling issue.

@rafayrty
Copy link
Copy Markdown
Contributor Author

rafayrty commented Aug 5, 2023

@danharrin

@danharrin danharrin added the bug Something isn't working label Aug 6, 2023
@danharrin danharrin added this to the v3 milestone Aug 6, 2023
@danharrin
Copy link
Copy Markdown
Member

Would be nice to have more info about the "scroll issue" as I have basically nothing to work from here. But I doubt this addition is gonna have negative effects.

@danharrin danharrin merged commit f75ff99 into filamentphp:2.x Aug 6, 2023
@rafayrty
Copy link
Copy Markdown
Contributor Author

rafayrty commented Aug 6, 2023

Hi @danharrin This issue was occurring on the tabs component already refer for more info on:
#6692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants