Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Org-Mode icon #88

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Update Org-Mode icon #88

merged 2 commits into from
Jun 2, 2021

Conversation

tecosaur
Copy link
Contributor

Hello!

I've recently submitted a simplified version of the Org icon to simple-icons in simple-icons/simple-icons#4889 after revamping the website (https://orgmode.org) last year. I think that file-icons could also benefit from the simplified version.

org-mode-ss

This simpler version of the Org mode icon is ~1/3 the size of the icon currently used here, and visually separates the mane from the rest of the head.

tecosaur and others added 2 commits April 17, 2021 16:11
Use a simpler version of the Org mode icon which is ~1/3 the size and visually separates the mane from the rest of the head.
@Alhadis
Copy link
Member

Alhadis commented Jun 2, 2021

Hey there, sorry for the torturous wait. This project's in an unofficial freeze at the moment while I figure out what the hell I'm doing with the project's pipeline. Merging new icons into the dev branch is a pain-in-the-arse, so I've been trying to avoid it when possible… 😀

As for the updated icon, I've cleaned up some redundant geometry and pushed the change to your branch. It also fixes an error that stops Adobe Illustrator from opening the file correctly (an arc-drawing command used a … 0 01 as coordinates, and Illustrator's SVG importer chokes on 01 (which is actually 0 1, not a zero-padded decimal 1).

This simpler version of the Org mode icon is ~1/3 the size of the icon currently used here

Just for the record, all of this repository's SVGs are saved with unrealistic levels of precision, because it's easier to optimise unnecessary detail than it is to add it once it's been lost. Tools like svgo and font generators will typically eliminate the exorbitant precision, anyway.

@Alhadis Alhadis merged commit 62f876b into file-icons:master Jun 2, 2021
@tecosaur
Copy link
Contributor Author

tecosaur commented Jun 2, 2021

Cool! I thought I did a pretty good job reducing the number of control points, but I see you found a bit more that could be tweaked.

Thanks for taking a look at this 😃

@Alhadis
Copy link
Member

Alhadis commented Jun 2, 2021

I thought I did a pretty good job reducing the number of control points, but I see you found a bit more that could be tweaked.

You did. But almost every SVG I come across contains redundant geometry in some form or another: duplicate control points, unnecessary Bézier handles, unclosed paths, etc…

I don't expect contributors to be as neurotic as I am when it comes to this level of optimisation, though. Hence the warning in the readme file. 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants