Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for Emacs and Orgmode #833

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

ashfinal
Copy link
Contributor

Description

Add icons for Emacs and Orgmode.

Requirements / Checklist

What does this Pull Request (PR) do?

I used Inkscape to edit the SVG files, then imported them into Fontforge. In the meanwhile, I uploaded the SVG files to IcoMoon to see if they triggered any warnings. And add them to original-source.otf as e532 and e533. Also, I update font-patcher to include new icons in patched fonts.

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Closes #342

Similar PR #429

Screenshots (if appropriate or helpful)

Changes in original-source.otf

fontforge

Patched font:

kfontview

Nvim with patched font:

nvim_devicons

Let me know if I miss something.
Thanks!

@Finii
Copy link
Collaborator

Finii commented May 21, 2022

Technical remark:

@ryanoasis I do not see how the src/svgs/ are converted to the original-source font. Is that really manual? Should maybe automated with for example font-custom and a fixed-codepoint configuration.

Additionally there is at least one glyph in original-source that is not in src/svgs/, origin unclear:

image

On the other hand src/svgs/go.svg is not included.

P.S. Oh man is font-custom old :->

@Finii
Copy link
Collaborator

Finii commented May 21, 2022

I think the orgmode svg is needlessly detailed (and thus big in file size). Maybe it can be simplified?

See also https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#3-optimize-the-icon

Just a gut feeling.

@Finii
Copy link
Collaborator

Finii commented May 21, 2022

Ah, and ... thanks for the contrib :-)

@ashfinal
Copy link
Contributor Author

ashfinal commented May 21, 2022

I think the orgmode svg is needlessly detailed (and thus big in file size). Maybe it can be simplified?

Good idea! I managed to reduce the size of orgmode using SVGO. (from 16.2 KiB to 5.5 KiB) Also I updated original-source.otf.

Let me know if I miss something. :)

@ashfinal
Copy link
Contributor Author

😸 I actually optimized SVGs before filing this PR. But there is a --precision argument I overlooked. Obviously orgmode svg could be smaller. As for emacs svg, I don't see much sense in this.

how the src/svgs/ are converted to the original-source font. Is that really manual?

I think that's manual. src/svgs is not much important, as you can easily export svgs from Fontforge. IMO, IcoMoon acts like some kind of QC measure in case your svgs are too complicated to be understood by IcoMoon. But I'm new to this project, I may be wrong. 😃

@Finii
Copy link
Collaborator

Finii commented May 21, 2022

how the src/svgs/ are converted to the original-source font. Is that really manual?

I think that's manual. src/svgs is not much important, as you can easily export svgs from Fontforge

It's the other way around. This repo should aim to assemble all its parts from the basic building blocks (in this case the svgs.).
Any manual steps are a burden and should be replaced by CI jobs. That was just a nudge for Ryan ;)

@Finii Finii mentioned this pull request Jul 8, 2022
2 tasks
@iris-garcia
Copy link

Any update here?

@Finii Finii merged commit 86c2247 into ryanoasis:master Sep 7, 2022
@tecosaur
Copy link

tecosaur commented Sep 8, 2022

Any reason why you didn't go for a simplified version of the Org logo? E.g.

org-mode-simplister

@Finii
Copy link
Collaborator

Finii commented Sep 8, 2022

Any reason why you didn't go for

Who is 'you'? :-)

I dont even know what orgmode is.
Answer is: Noone suggested that.
What do orgmode users prefer/expect?

@tecosaur
Copy link

tecosaur commented Sep 8, 2022

Who is 'you'? :-)

You = the author of the PR.

The merged version is the full-detail outline, but as I think of nerd-font being used at smaller sizes I wonder if a simplified form would be more appropriate. When re-doing the website (https://orgmode.org) last year, I created a range of detail levels of the logo. The reduced-detail version I shared above is now used in the file-icons package as of file-icons/icons#88.

@Finii
Copy link
Collaborator

Finii commented Sep 8, 2022

Thanks!
I will try to come up with a PR.

@tecosaur
Copy link

tecosaur commented Sep 8, 2022

Cool. If you do whip up a PR from this, you'll probably be most interested in file-icons' optimised path version: https://raw.githubusercontent.com/file-icons/icons/master/svg/Org-Mode.svg.

Finii added a commit that referenced this pull request Sep 8, 2022
[why]
The glyph is needlessly detailed (for a font).
There is another, more simple glyph, which is also used by fileicons.

More details see PR #833.

Reported-by: tecosaur <contact@tecosaur.net>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii mentioned this pull request Sep 8, 2022
2 tasks
@Finii
Copy link
Collaborator

Finii commented Sep 8, 2022

Want to have a look before I merge?
I'm not sure with the aspect ratio, looks a bit 'wide' in original-source.otf, but that might be normal for that unicorn :-)

image

Great job with the simplified icon, btw 👍

Edit: Add where it looks a bit wide, the SVG is just a copy, but I scaled it up in ff
Edit: Add image, ... maybe just imagination

@4e554c4c 4e554c4c mentioned this pull request Sep 15, 2022
2 tasks
Finii added a commit that referenced this pull request Sep 22, 2022
[why]
The glyph is needlessly detailed (for a font).
There is another, more simple glyph, which is also used by fileicons.

More details see PR #833.

Reported-by: tecosaur <contact@tecosaur.net>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit that referenced this pull request Sep 22, 2022
[why]
The glyph is needlessly detailed (for a font).
There is another, more simple glyph, which is also used by fileicons.

More details see PR #833.

Reported-by: tecosaur <contact@tecosaur.net>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] icons for Emacs, elisp and orgmode
4 participants