Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete extra remove prefix #1186

Merged
merged 1 commit into from Dec 16, 2020
Merged

Conversation

WeidiDeng
Copy link
Contributor

@WeidiDeng WeidiDeng commented Dec 15, 2020

Description
When there is a folder named files in the user root directory, copy, rename, move will fail.

These operations call moveCopy function. Note the strip prefix. However, in turn this function calls resourceAction which strips prefix yet again. moveCopy's strip is unnecessary in this case.

馃毃 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • DO make sure that related issues are opened in other repositories. I.e., the frontend, caddy plugins or the web page need to be updated accordingly.
  • AVOID breaking the continuous integration build.

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

鉂わ笍 Thank you!

@o1egl o1egl merged commit 7a5298a into filebrowser:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants