Add EXIF thumbnail support for JPEG files #1234

adrium · 2021-01-06T23:59:13Z

Description
Compact implementation to support EXIF thumbnails. Listing a directory with a lot of thumbnails will be a lot faster. The following was recorded with the master branch and with the feature proposed here. The app runs on a Raspberry Pi 4b accessing files on a hard disk.

requesting to pull a topic/feature/bugfix branch
pull request against the master branch
File Browser can be successfully built
no issues are opened in other repositories
continuous integration build passed

adrium · 2021-01-07T00:14:59Z

img/service.go:226:11: ineffectual assignment to `err` (ineffassign)
					thm, err = index.RootIfd.NextIfd().Thumbnail()
					     ^
img/service.go:161:7: shadow: declaration of "err" shadows declaration at line 143 (govet)
			_, err := out.Write(thm)
			   ^
img/service.go:221:8: shadow: declaration of "err" shadows declaration at line 202 (govet)
			im, err := exifcommon.NewIfdMappingWithStandard()
			    ^

Those assignments are actually effective...

img/service.go:14: File is not `goimports`-ed with -local github.com/filebrowser/filebrowser (goimports)
	"github.com/dsoprea/go-exif/v3/common"

How can I fix the import error?

adrium · 2021-01-07T15:39:15Z

Fixed CI, all set 🚀

adrium · 2021-01-09T10:32:13Z

Latest updated includes a fix for thumbnail distortion. object-fit: cover is added to stylesheet.
Also rebased to latest master.

niubility000 · 2021-02-01T06:36:33Z

It's pretty cool. very very fast and smooth!
But for some pics, it just didn't show the thumbnails. Would you please fix that. Maybe in this situation, just allow the filebrowser to generate the thumknails for those pics. Here 's the screenshot and some that kind of pics.
TMP.zip

adrium · 2021-02-02T22:21:09Z

Thanks for reporting. Reason was because EXIF exists, but does not contain a thumbnail in the files provided.

This is fixed in the newest version of the pull request. Additionally, it was rebased onto master and added the feat: prefix to the commit message.

niubility000 · 2021-02-03T08:09:27Z

Wow, I checked it. Perfect!! very fast! especially for the folder with tons of pics. and it 's pretty cool for the low-end server!

niubility000 · 2021-02-05T02:49:02Z

Oops, I just found a small bug. For some pictures, It looks like the thumbnails are broken, only shows half of them. Would you please check out these pics?
temp.zip

adrium · 2021-02-05T19:10:46Z

Hi niubility, thanks for testing this PR so thoroughly.
Let's hope it will make into the master branch eventually.

The thumbnails in your files were larger than the preloaded size of 32k.
In the examples I had, a lot of thumbnails were around 16k that's why I chose the value of 32k.

Theoretically, Exif data (including the thumbnails) must fit in the APP1 marker and all JPEG markers can be max 64k.
The preload size is now 0xffff and it will be hopefully be sufficiently large.

adrium · 2021-02-05T22:10:33Z

Improved code style

niubility000 · 2021-02-06T01:44:36Z

Great! I have tried. It's wonderful!
and the file list's loading speed is amazing fast! I don't need to wait like half a minute for that anymore.

o1egl

Please add tests

o1egl · 2021-03-01T10:20:31Z

img/service.go

+	wrappedReader := io.MultiReader(buf, in)
+
+	offset := 0
+	offsets := []int{12, 30}


Can you please explain why are you checking those offsets only?

Those are the two most common offsets where the Exif starts in JPEG files. To avoid more complex parsing (and library dependencies), it only checks those offsets.

If no Exif is found, it will fall back to the downscaling method.

I checked that in the provided library the different approach is used https://github.com/dsoprea/go-exif/blob/d154f10435cc/v3/exif.go#L52

Indeed. And that's the approach in the first (unpublished) attempt. That function tries to find an exif in brute-force fashion byte by byte scanning the whole file: https://github.com/dsoprea/go-exif/blob/d154f10435cc6ae4b64cd68eed04a1d005b73ec7/v3/exif.go#L150

It is more efficient by just checking the most common offsets for exif and there was a noticeable performance increase.

adrium · 2021-03-02T07:47:31Z

Writing tests will require quite some effort... I will look into it when I have time

o1egl · 2021-03-02T10:06:12Z

go.mod

@@ -10,6 +10,7 @@ require (
 	github.com/dgrijalva/jwt-go v3.2.0+incompatible
 	github.com/disintegration/imaging v1.6.2
 	github.com/dsnet/compress v0.0.1 // indirect
+	github.com/dsoprea/go-exif/v3 v3.0.0-20201216222538-db167117f483 // indirect


Why not stick to version v3.0.0?

Honestly no clue. That was added by go get automatically...

Fix it, please

I looked into this and tried to stick to the version number you mentioned. However, the library does not seem provide tagged releases:

:~/Code/filebrowser*master$ go get -d github.com/dsoprea/go-exif/v3@v3.0.0 go get: github.com/dsoprea/go-exif/v3@v3.0.0: invalid version: unknown revision v3.0.0 :~/Code/filebrowser*master$ go get -d github.com/dsoprea/go-exif/v3@3.0.0 go: downloading github.com/dsoprea/go-exif v0.0.0-20200711180620-208788de2815 go get: module github.com/dsoprea/go-exif@3.0.0 found (v0.0.0-20200711180620-208788de2815), but does not contain package github.com/dsoprea/go-exif/v3

The library is pulled as recommended. Other projects use the library in a similar way. Examples are PhotoPrism (listed on Awesome-Selfhosted) and other projects on GitHub:

PhotoPrism

GoGallery

Collage

photoimportd

As such, the dependency file should probably be kept as committed.

adrium · 2021-03-07T15:26:25Z

Please add tests

Constructing pictures programmatically requires a lot of code and is error-prone in itself.

On the other hand, the pictures provided by niubility000 are a very useful set and are "real" data.
I propose to use those pictures to create the tests (if the user agrees). The extracted thumbnails could be compared to the expected hash values.

Do you prefer a specific structure to check in the files?

o1egl · 2021-03-08T18:20:18Z

@adrium I agree that using image files will be better for that. If you plan to add table tests, please look at https://github.com/filebrowser/filebrowser/blob/master/img/service_test.go for a reference.

adrium · 2021-03-09T23:18:35Z

@o1egl Thanks a lot for your feedback.

@niubility000 Do you agree to make use of the pictures you provided for testing and thereby checking them in into this repo?

adrium · 2021-03-29T06:32:56Z

Tests added. Image credits:

20130612_142406.jpg @niubility000 assumed usage permission because of upload in this PR
IMG_2578.JPG @niubility000 assumed usage permission because of upload in this PR
gray-sample.jpg https://github.com/haraldk/TwelveMonkeys

o1egl

LGTM

niubility000 · 2022-09-21T03:07:11Z

I just found a bug: #2137

adrium force-pushed the fast-thumbnails branch from da363f4 to ed50faf Compare January 7, 2021 00:10

adrium force-pushed the fast-thumbnails branch 2 times, most recently from 7968bb3 to c7c2439 Compare January 7, 2021 15:16

adrium force-pushed the fast-thumbnails branch 2 times, most recently from 45d08f8 to 2bcfb3b Compare January 9, 2021 10:12

adrium force-pushed the fast-thumbnails branch 2 times, most recently from 3d12d2b to f22c4eb Compare February 2, 2021 22:16

niubility000 mentioned this pull request Feb 4, 2021

allow navigation information to be cached #1233

Closed

5 tasks

adrium force-pushed the fast-thumbnails branch from f22c4eb to 9fe500c Compare February 5, 2021 19:00

adrium force-pushed the fast-thumbnails branch from 9fe500c to be495f2 Compare February 5, 2021 22:06

o1egl requested changes Mar 1, 2021

View reviewed changes

o1egl reviewed Mar 2, 2021

View reviewed changes

adrium force-pushed the fast-thumbnails branch from be495f2 to c255d25 Compare March 7, 2021 15:55

adrium force-pushed the fast-thumbnails branch from c255d25 to 28677a2 Compare March 29, 2021 06:20

feat: add EXIF thumbnail support for JPEG files

15456b7

adrium force-pushed the fast-thumbnails branch from 28677a2 to 15456b7 Compare March 29, 2021 06:28

o1egl approved these changes Mar 29, 2021

View reviewed changes

o1egl merged commit 7dd5b34 into filebrowser:master Mar 29, 2021

adrium deleted the fast-thumbnails branch March 29, 2021 20:05

Alsan pushed a commit to Alsan/filebrowser that referenced this pull request Aug 25, 2021

feat: add EXIF thumbnail support for JPEG files (filebrowser#1234)

715e08f

adrium mentioned this pull request Jan 11, 2022

Show pic's location #1677

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EXIF thumbnail support for JPEG files #1234

Add EXIF thumbnail support for JPEG files #1234

adrium commented Jan 6, 2021 •

edited

Loading

adrium commented Jan 7, 2021

adrium commented Jan 7, 2021

adrium commented Jan 9, 2021

niubility000 commented Feb 1, 2021

adrium commented Feb 2, 2021

niubility000 commented Feb 3, 2021

niubility000 commented Feb 5, 2021

adrium commented Feb 5, 2021

adrium commented Feb 5, 2021

niubility000 commented Feb 6, 2021 •

edited

Loading

o1egl left a comment

o1egl Mar 1, 2021

adrium Mar 2, 2021 •

edited

Loading

o1egl Mar 2, 2021

adrium Mar 3, 2021

adrium commented Mar 2, 2021

o1egl Mar 2, 2021

adrium Mar 3, 2021

o1egl Mar 4, 2021

adrium Mar 7, 2021

adrium commented Mar 7, 2021

o1egl commented Mar 8, 2021

adrium commented Mar 9, 2021

adrium commented Mar 29, 2021

o1egl left a comment

niubility000 commented Sep 21, 2022

Add EXIF thumbnail support for JPEG files #1234

Add EXIF thumbnail support for JPEG files #1234

Conversation

adrium commented Jan 6, 2021 • edited Loading

adrium commented Jan 7, 2021

adrium commented Jan 7, 2021

adrium commented Jan 9, 2021

niubility000 commented Feb 1, 2021

adrium commented Feb 2, 2021

niubility000 commented Feb 3, 2021

niubility000 commented Feb 5, 2021

adrium commented Feb 5, 2021

adrium commented Feb 5, 2021

niubility000 commented Feb 6, 2021 • edited Loading

o1egl left a comment

Choose a reason for hiding this comment

o1egl Mar 1, 2021

Choose a reason for hiding this comment

adrium Mar 2, 2021 • edited Loading

Choose a reason for hiding this comment

o1egl Mar 2, 2021

Choose a reason for hiding this comment

adrium Mar 3, 2021

Choose a reason for hiding this comment

adrium commented Mar 2, 2021

o1egl Mar 2, 2021

Choose a reason for hiding this comment

adrium Mar 3, 2021

Choose a reason for hiding this comment

o1egl Mar 4, 2021

Choose a reason for hiding this comment

adrium Mar 7, 2021

Choose a reason for hiding this comment

adrium commented Mar 7, 2021

o1egl commented Mar 8, 2021

adrium commented Mar 9, 2021

adrium commented Mar 29, 2021

o1egl left a comment

Choose a reason for hiding this comment

niubility000 commented Sep 21, 2022

adrium commented Jan 6, 2021 •

edited

Loading

niubility000 commented Feb 6, 2021 •

edited

Loading

adrium Mar 2, 2021 •

edited

Loading