feat: Imprement jwt-auth header auth method #2961
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| package auth | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "net/http" | ||
| "os" | ||
| "sync" | ||
|
|
||
| "github.com/coreos/go-oidc/v3/oidc" | ||
|
|
||
| fbErrors "github.com/filebrowser/filebrowser/v2/errors" | ||
| "github.com/filebrowser/filebrowser/v2/settings" | ||
| "github.com/filebrowser/filebrowser/v2/users" | ||
| ) | ||
|
|
||
| // MethodJWTAuth is used to identify JWTAuth auth. | ||
| const MethodJWTAuth settings.AuthMethod = "jwt-header" | ||
|
|
||
| // JWTAuth is a JWTAuth implementation of an auther. | ||
| type JWTAuth struct { | ||
| CertsURL string `json:"certsurl"` | ||
| Aud string `json:"aud"` | ||
| Iss string `json:"iss"` | ||
| UsernameClaim string `json:"usernameClaim"` | ||
| Header string `json:"header"` | ||
| remoteKeySet *oidc.RemoteKeySet | ||
| init sync.Once | ||
| } | ||
|
|
||
| // Auth authenticates the user via a JWT token in an HTTP header. | ||
| func (a *JWTAuth) Auth(r *http.Request, usr users.Store, stg *settings.Settings, srv *settings.Server) (*users.User, error) { | ||
| a.init.Do(func() { | ||
| a.remoteKeySet = oidc.NewRemoteKeySet(context.Background(), a.CertsURL) | ||
| }) | ||
|
|
||
| accessJWT := r.Header.Get(a.Header) | ||
| if accessJWT == "" { | ||
| return nil, os.ErrPermission | ||
|
There was a problem hiding this comment. It would be nice to log an error here |
||
| } | ||
|
|
||
| // The Application Audience (AUD) tag for your application | ||
| config := &oidc.Config{ | ||
| ClientID: a.Aud, | ||
| } | ||
|
|
||
| verifier := oidc.NewVerifier(a.Iss, a.remoteKeySet, config) | ||
|
Comment on lines
+42
to
+47
There was a problem hiding this comment. Looks like a good candidate to be moved into the constructor |
||
|
|
||
| token, err := verifier.Verify(r.Context(), accessJWT) | ||
| if err != nil { | ||
| return nil, os.ErrPermission | ||
|
|
||
| } | ||
|
|
||
| payload := map[string]any{} | ||
| err = token.Claims(&payload) | ||
| if err != nil { | ||
| return nil, os.ErrPermission | ||
|
|
||
| } | ||
|
|
||
| user, err := usr.Get(srv.Root, payload[a.UsernameClaim]) | ||
| if errors.Is(err, fbErrors.ErrNotExist) { | ||
| return nil, os.ErrPermission | ||
|
|
||
| } | ||
|
|
||
| return user, err | ||
| } | ||
|
|
||
| // LoginPage tells that proxy auth doesn't require a login page. | ||
| func (a *JWTAuth) LoginPage() bool { | ||
| return false | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to do it in the constructor func