Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of Synthetic PoRep (FIP-0059) #627

Merged
merged 4 commits into from
Mar 5, 2023
Merged

First draft of Synthetic PoRep (FIP-0059) #627

merged 4 commits into from
Mar 5, 2023

Conversation

irenegia
Copy link
Contributor

FIP draft for the synthetic porep protocol
cc @lucaniz @nicola @Kubuxu

FIP draft for the synthetic porep protocol
cc @lucaniz @nicola @Kubuxu
fip-00xx.md Outdated
3. **Storage Provider can remove layers data**
1. As the Storage Provider knows responses to all possible challenges that will be asked in the interactive step, he can remove the layers data which is needed to respond to challenges.
4. **Storage Provider publishes “PreCommitsSector”**
1. Using the same flow as today Storage Provider submits the sector for PreCommit.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this exactly the same PreCommit method/s used today, or do we need a new parameter to indicate that synthetic PoRep is to be used at proof time?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would use a new PoRep version/type. The handling on the side of actors is equivalent between interactive and synthetic-interactive PoReps.

@anorth
Copy link
Member

anorth commented Mar 2, 2023

Just noting that I don't think this FIP is ready for final consideration yet. The specification is not yet detailed enough to implement. E.g., at a minimum it must specify a new PoRep proof type, and then how that new type is to be used in code. The current specification is more of a workflow description, but we need a spec of the functional changes to built-in actor code (and any other consensus-relevant pieces).

This can still merge, but it's not ready to go yet.

As requested by @anorth, we added mode details in the Specification section (both for actor changes and for proofs)
Note that the paragraph for proofs change may be updated later on once the fil-crypto team has more data from testing different options.
@irenegia
Copy link
Contributor Author

irenegia commented Mar 3, 2023

@anorth: details added in the spec section!
Can we get your approval now? Thanks! :)

@anorth anorth changed the title Create fip-00xx.md (synthetic porep fip draft) First draft of Synthetic PoRep (FIP-0059) Mar 5, 2023
@anorth anorth merged commit 1002b19 into master Mar 5, 2023
@anorth anorth deleted the synthetic-porep branch March 5, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants