FRC: Piece Multihash CID #758
Conversation
aschmahmann
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle,
anorth and
raulk
as code owners
aschmahmann
force-pushed
the
frc/piece-multihash
branch
3 times, most recently
from
d46b437
to
bc5557a
Compare
FRCs/piece-multihash.md
Outdated
| @@ -0,0 +1,84 @@ | |||
| | fip | title | author | discussions-to | status | type | created | | |||
| | --- | --- | --- | --- | --- | --- | --- | | |||
| | TBD | Piece Multihash | Adin Schmahmann (@aschmahmann), Peter Rabbitson (@ribasushi), ... | https://github.com/filecoin-project/FIPs/discussions/759 | Draft | FRC | 2023-MM-DD | | |||
There was a problem hiding this comment.
Please follow the vertical table format from the template. The FIP number and author list need to be quoted.
There was a problem hiding this comment.
Thanks @anorth. I just copied the format from #709, but I see that got fixed up in #762. Should be resolved now. Let me know if there are any other procedural issues to correct here (or you have any thoughts on the FRC itself 😄).
For example, when are FRC numbers assigned and is the creation date when the PR is opened or the day it's merged?
There was a problem hiding this comment.
Everything else looks fine from an editorial standpoint. I will reserve discussion of the content for the discussion forum, but don't think I have much to add to what's already there.
The date can be either, the FIP number will be assigned and filled in by an editor.
Defines an alternative CID representation for Filecoin Piece Commitments (i.e. CommP)
aschmahmann
force-pushed
the
frc/piece-multihash
branch
from
bc5557a
to
45a9d1c
Compare
Updated number and location
|
@kaitlin-beegle I'm still hoping to see some conversations around this FIP resolved before finalizing it. Is it ok to make PRs to this FRC document (0069) or are changes expected to be per-FRC number? |
|
Yes, it's totally ok to make PRs to this FRC document. |
Defines an alternative CID representation for Filecoin Piece Commitments (i.e. CommP)
Rendered Version
Discussion in #759