Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't name executor that doesn't exist (enums) #248

Closed
lukemarsden opened this issue Jun 15, 2022 · 0 comments
Closed

Can't name executor that doesn't exist (enums) #248

lukemarsden opened this issue Jun 15, 2022 · 0 comments
Assignees
@Bubblyworld

Comments

@lukemarsden
Copy link
Contributor

We want it to be harder for users to name an executor in a job request that doesn't exist. Switch from using strings to strongly typed enums, or some other method for ensuring they are typo-proof.
@Bubblyworld Bubblyworld mentioned this issue Jun 20, 2022
Merged
simonwo pushed a commit that referenced this issue Dec 6, 2023
@fakela
Delete index.html (#248)
f3199b5
olgibbons added a commit that referenced this issue Jan 11, 2024
@olgibbons
Fix Error handling and reporting for docker OOM
8d2876a 
When a docker container exceeds memory limits (OOM status = true) An informative error message will be relayed
to the user.

Have also implemented a test that will trigger OOM errors.

Fixes issues #249 #248
@olgibbons olgibbons mentioned this issue Jan 11, 2024
Merged
olgibbons added a commit that referenced this issue Jan 11, 2024
@olgibbons
Fix Error handling and reporting for docker OOM
69d2092 
When a docker container exceeds memory limits (OOM status = true) An informative error message will be relayed
to the user.

Have also implemented a test that will trigger OOM errors.

Fixes issues #249 #248
olgibbons added a commit that referenced this issue Jan 11, 2024
@olgibbons
Fix Error handling and reporting for docker OOM
2042634 
When a docker container exceeds memory limits (OOM status = true) An informative error message will be relayed
to the user.

Have also implemented a test that will trigger OOM errors.

Fixes issues #249 #248
olgibbons added a commit that referenced this issue Jan 11, 2024
@olgibbons
Update docker executor for oom (#3230)
7c5fde1 
When a docker container exceeds memory limits (OOM status = true) An
informative error message will be relayed to the user.

Have also implemented a test that will trigger OOM errors. NB: The test
currently uses the error message as a signal for an error occurring, so
if the message is changed, the test may need to be updated as well


Fixes issues #249 #248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bubblyworld Bubblyworld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukemarsden @Bubblyworld