Move types into relevant packages, use strong typing for executor enums. #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronchick
pushed a commit
that referenced
this pull request
Jun 22, 2022
…ms. (#265) * Rename to types, add constants for executor/verifier. * Migrate types to relevant internal packages. * Start migrating usage of types across the codebase. * Fix build after all the refactoring and type changes. * Fix tests after refactor.
aronchick
pushed a commit
that referenced
this pull request
Jun 24, 2022
…ms. (#265) * Rename to types, add constants for executor/verifier. * Migrate types to relevant internal packages. * Start migrating usage of types across the codebase. * Fix build after all the refactoring and type changes. * Fix tests after refactor.
aronchick
pushed a commit
that referenced
this pull request
Jun 24, 2022
…ms. (#265) * Rename to types, add constants for executor/verifier. * Migrate types to relevant internal packages. * Start migrating usage of types across the codebase. * Fix build after all the refactoring and type changes. * Fix tests after refactor.
aronchick
pushed a commit
that referenced
this pull request
Jun 24, 2022
…ms. (#265) * Rename to types, add constants for executor/verifier. * Migrate types to relevant internal packages. * Start migrating usage of types across the codebase. * Fix build after all the refactoring and type changes. * Fix tests after refactor.
simonwo
pushed a commit
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #248. Uses strong types for enums instead of strings (at least for
executors, storage is still TODO). To avoid circular dependencies I had to move
a lot of the types out of
types.goand into theexecutor/storage/etcpackages. Probably good to decouple them early though.