Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker executor for oom #3230

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Update docker executor for oom #3230

merged 3 commits into from
Jan 11, 2024

Conversation

olgibbons
Copy link
Contributor

@olgibbons olgibbons commented Jan 11, 2024 •
edited by rossjones
Loading

When a docker container exceeds memory limits (OOM status = true) An informative error message will be relayed to the user.

Have also implemented a test that will trigger OOM errors. NB: The test currently uses the error message as a signal for an error occurring, so if the message is changed, the test may need to be updated as well

Fixes #2965

@olgibbons olgibbons force-pushed the update_docker_executor_for_OOM branch from 8d2876a to 69d2092 Compare January 11, 2024 17:05
rossjones
rossjones approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@rossjones rossjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge when the checks have completed.

@olgibbons olgibbons enabled auto-merge (squash) January 11, 2024 17:14
@olgibbons
Fix Error handling and reporting for docker OOM
2042634 
When a docker container exceeds memory limits (OOM status = true) An informative error message will be relayed
to the user.

Have also implemented a test that will trigger OOM errors.

Fixes issues #249 #248
@olgibbons olgibbons force-pushed the update_docker_executor_for_OOM branch from 69d2092 to 2042634 Compare January 11, 2024 17:32
@olgibbons olgibbons disabled auto-merge January 11, 2024 17:34
@olgibbons olgibbons merged commit 7c5fde1 into main Jan 11, 2024
11 checks passed
@olgibbons olgibbons deleted the update_docker_executor_for_OOM branch January 11, 2024 17:45
@rossjones rossjones mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossjones rossjones rossjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI gives poor error messages when container runs out of memory
2 participants
@olgibbons @rossjones