Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_groth16_aggregation fails when run with 2 threads #197

Closed
vmx opened this issue Jun 15, 2021 · 0 comments · Fixed by #198
Closed

test_groth16_aggregation fails when run with 2 threads #197

vmx opened this issue Jun 15, 2021 · 0 comments · Fixed by #198

Comments

@vmx
Copy link

vmx commented Jun 15, 2021

Description

When running RAYON_NUM_THREADS=2 cargo test --release --tests test_groth16_aggregation -- --exact, it fails with:

thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', /tmp/bellman/src/groth16/aggregate/accumulator.rs:152:41

Acceptance criteria

Test should successfully pass.

Risks + pitfalls

No risk with fixing it, but there is a more general risk that there are more parallelism bugs as we use Rayon in combination with sending messages.

Where to begin

Run the test.
@vmx vmx transferred this issue from filecoin-project/rust-fil-proofs Jun 15, 2021
vmx added a commit that referenced this issue Jun 15, 2021
@vmx
fix: don't panic if channel was intentionally closed
e8e7ee4 
The channel messages are sent to might have been intentionally been
closed. Don't error if that is the case.

Closes #197.
This was referenced Jun 15, 2021
Merged
Open
@vmx vmx closed this as completed in #198 Jun 16, 2021
vmx added a commit that referenced this issue Jun 16, 2021
@vmx
fix: don't panic if channel was intentionally closed (#198)
33acfc0 
* fix: don't panic if channel was intentionally closed

The channel messages are sent to might have been intentionally been
closed. Don't error if that is the case.

Closes #197.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't panic if channel was intentionally closed filecoin-project/bellperson
1 participant
@vmx