fix: don't panic if channel was intentionally closed #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The channel messages are sent to might have been intentionally been closed. Don't error if that is the case. Closes #197.
|
@nikkolasg is that a correct fix, or shouldn't merge calls happen after it it is invalidated? |
|
@nikkolasg Please review as welll |
|
Am currently in discussion with @vmx : I dont believe this correctly fixes the issue. |
nikkolasg
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
Approving in advance. We have discussed and searched with VMX a lot this afternoon, he finally found the underlying issue. We agreed that he will comment on it and we move forward with this solution, which is still a bandaid but should fix the issue. Later on, a proper re-factoring of this accumulator piece should be done.
|
I've opened an issue for tracking future improvements that contains the information I gathered today: #199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The channel messages are sent to might have been intentionally been
closed. Don't error if that is the case.
Closes #197.