forked from zkcrypto/bellman
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update APIs and dependencies #274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: fixing random-z with different versions feat: properly support V1 and V2 agg proving/verify feat: add some info/debug regarding which agg version is used refactor transcript generation fix: remove unused logging dep Co-authored-by: nikkolasg <nikkolasg@gmail.com> Co-authored-by: dignifiedquire <me@dignifiedquire.com>
feat: add versioning to new aggregation APIs
cryptonemo
requested review from
DrPeterVanNostrand,
vmx,
dignifiedquire and
nikkolasg
June 14, 2022 12:06
cryptonemo
commented
Jun 14, 2022
Cargo.toml
Outdated
@@ -89,3 +89,9 @@ members = [ | |||
|
|||
[build-dependencies] | |||
rustversion = "1.0.6" | |||
|
|||
|
|||
[patch.crates-io] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIXME: Update patches to real releases before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
This was referenced Jun 14, 2022
dignifiedquire
approved these changes
Jun 14, 2022
vmx
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.