Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show network name in binary versions #1642

Merged
merged 9 commits into from
Aug 28, 2023
Merged

feat: show network name in binary versions #1642

merged 9 commits into from
Aug 28, 2023

Conversation

LexLuthr
Copy link
Collaborator

@LexLuthr LexLuthr commented Aug 23, 2023 •
edited
Loading

Fixes #1623 partially

This PR enhances the build command to build with network name

I have seen multiple times where users build a binary for calibnet or devnet and then try to use it for mainnet. This is mostly due to the fact that we don't show the network name in the --version.

% make debug             
rm -f boost
go build  -ldflags="-X=github.com/filecoin-project/boost/build.CurrentCommit=+git.8f88bde.dirty" -tags=debug -o boost ./cmd/boost
rm -f boostd
................
lexluthr@Lexs-Mac boost % ./boost --version
boost version 2.0.0-rc1+debug+git.8f88bde.dirty
lexluthr@Lexs-Mac boost % ./boostd-data --version
boostd-data version 1.4.0+mainnet+git.8f88bde.dirty

 make calibnet
Node.js version v16.13.2 is supported.
.............
rm -f boost
go build  -ldflags="-X=github.com/filecoin-project/boost/build.CurrentCommit=+git.8f88bde.dirty" -tags=calibnet -o boost ./cmd/boost
rm -f boostd
...................
lexluthr@Lexs-Mac boost % ./boost version 
No help topic for 'version'
lexluthr@Lexs-Mac boost % ./boost --version
boost version 2.0.0-rc1+calibnet+git.8f88bde.dirty
lexluthr@Lexs-Mac boost % ./boostd-data --version
boostd-data version 1.4.0+mainnet+git.8f88bde.dirty

make build             
Node.js version v16.13.2 is supported.
...............
rm -f boost
go build  -ldflags="-X=github.com/filecoin-project/boost/build.CurrentCommit=+git.8f88bde.dirty" -o boost ./cmd/boost
................
lexluthr@Lexs-Mac boost % ./boost --version
boost version 2.0.0-rc1+mainnet+git.8f88bde.dirty
lexluthr@Lexs-Mac boost % ./boostd-data --version
boostd-data version 1.4.0+mainnet+git.8f88bde.dirty

@LexLuthr LexLuthr marked this pull request as draft August 23, 2023 11:29
@LexLuthr LexLuthr linked an issue Aug 23, 2023 that may be closed by this pull request
mmlid: The miner address in deals is being stored with a t address #1623
Closed
nonsense
nonsense reviewed Aug 24, 2023
View reviewed changes
build/version.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr changed the title fix: miner address in Yugabyte tables feat: show network name in binary versions Aug 25, 2023
@LexLuthr LexLuthr marked this pull request as ready for review August 25, 2023 09:12
@LexLuthr LexLuthr requested a review from dirkmc August 25, 2023 09:18
dirkmc
dirkmc reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One correction but otherwise looks great 👍

Let's also revert changes to go.mod and go.sum

build/params_mainnet.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr requested a review from dirkmc August 28, 2023 08:43
dirkmc
dirkmc reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also undo the changes to the yugabyte directory as they will conflict with #1648

Otherwise LGTM 👍

@LexLuthr LexLuthr requested a review from dirkmc August 28, 2023 11:20
@LexLuthr LexLuthr merged commit 162fdc8 into feat/mm-retrieve Aug 28, 2023
18 checks passed
@LexLuthr LexLuthr deleted the fix/networkAddress branch August 28, 2023 11:30
LexLuthr added a commit that referenced this pull request Aug 30, 2023
@LexLuthr @dirkmc @nonsense
feat: add multi-miner to single LID support (#1656)
2412aa6 
* feat: retrieve data served from multiple miners (#1578)

* add booster-http multi-miner retrieve test (#1598)

* feat: add booster-http multi-miner retrieve test

* refactor: move api version check to its own function

* test: add booster-bitswap multi-miner test (#1599)

* multi-miner / single LID - piece doctor (#1600)

* wip: multi-miner / 1 LID - piece doctor

* refactor: move yugabyte migration details into a separate class

* fix: add miner address to yugabyte / leveldb impl

* refactor: update log in piece doctor no deals for miner to warning

* refactor: break migration into two parts to avoid migrations bug

* feat: skip set address in migration if PieceTracker table has no rows (#1614)

* fix: split PieceTracker and PieceFlagged migrations (#1615)

* fix: yugabyte migrate command name

* Add miner address to top of page in boost UI (#1633)

* feat: add miner address to top of page in boost UI

* Update react/src/MinerAddress.js

Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com>

---------

Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com>

* refactor: move StorageAccessApiInfo config into DealMaking at GraphsyncStorageAccessApiInfo (#1634)

* Show list of retrieval miners on retrievals list page (#1637)

* feat: show list of retrieval miners on retrievals list page

* fix: retrieval miner address resolver

* fix: mmlid fixes for LID UI (#1639)

* fix: look up unseal status against multi-miner accessor (rather than just on local miner) (#1641)

* Show warning on piece doctor page if still doing initial scan (#1643)

* fix: look up unseal status against multi-miner accessor (rather than just on local miner)

* feat: show warning on piece doctor page if still doing initial scan

* Update extern/boostd-data/yugabyte/piecedoctor.go

Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>

* Update extern/boostd-data/yugabyte/piecedoctor.go

---------

Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>

* feat: change postgres timezone type to include timezone (#1645)

* feat: show network name in binary versions (#1642)

* fix boostd-data maddr, enhance build

* add CQL migrator

* refactor migrator

* modify migrate query

* remove idx from migrate query

* remove CQL migrator

* undo go mod changes, fix mainnet build

* undo yugabyte changes

* remove extra line

* Cassandra migrations (#1648)

* feat: cassandra migrations

* refactor: dbname -> appliedMigration

* fix: yugabyte lid test

* feat: add postgres migration

* refactor: simplify cassandra migrations

* fix: delete duplicate rows in PieceTracker table

* fix test

---------

Co-authored-by: dirkmc <dirkmdev@gmail.com>
Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonsense nonsense nonsense left review comments

@dirkmc dirkmc dirkmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mmlid: The miner address in deals is being stored with a t address
3 participants
@LexLuthr @nonsense @dirkmc