Show warning on piece doctor page if still doing initial scan #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…just on local miner)
dirkmc
force-pushed
the
feat/mm-retreive-doctor-warn
branch
from
8cd422c
to
017af78
Compare
dirkmc
force-pushed
the
feat/mm-retreive-doctor-warn
branch
from
017af78
to
2774382
Compare
nonsense
reviewed
Aug 24, 2023
| @@ -27,6 +27,7 @@ type Store struct { | |||
| GetOffsetSize func(context.Context, cid.Cid, mh.Multihash) (*model.OffsetSize, error) | |||
| ListPieces func(ctx context.Context) ([]cid.Cid, error) | |||
| PiecesCount func(ctx context.Context, maddr address.Address) (int, error) | |||
| ScanProgress func(ctx context.Context, maddr address.Address) (*types.ScanProgress, error) | |||
There was a problem hiding this comment.
The API for boostd-data has exploded quite a bit with auxiliary functionality.
I wonder if we can refactor in the future and split into 2 APIs -- one for critical functionality that one needs to implement if they want their own adapter for a new database (such as PostgreSQL with Citus), and one for auxiliary functionality that we build - Piece Doctor, UI feedback (such as ScanProgress), etc.
Just a thought as we keep on adding new methods here, no action required at this time.
There was a problem hiding this comment.
That's true, we are adding a bunch of new methods 👍
nonsense
reviewed
Aug 24, 2023
nonsense
reviewed
Aug 24, 2023
nonsense
approved these changes
Aug 24, 2023
Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
dirkmc
commented
Aug 24, 2023
Base automatically changed from
feat/mm-retrieve-fix-seal-status
to
feat/mm-retrieve
August 24, 2023 10:55
LexLuthr
added a commit
that referenced
this pull request
Aug 30, 2023
* feat: retrieve data served from multiple miners (#1578) * add booster-http multi-miner retrieve test (#1598) * feat: add booster-http multi-miner retrieve test * refactor: move api version check to its own function * test: add booster-bitswap multi-miner test (#1599) * multi-miner / single LID - piece doctor (#1600) * wip: multi-miner / 1 LID - piece doctor * refactor: move yugabyte migration details into a separate class * fix: add miner address to yugabyte / leveldb impl * refactor: update log in piece doctor no deals for miner to warning * refactor: break migration into two parts to avoid migrations bug * feat: skip set address in migration if PieceTracker table has no rows (#1614) * fix: split PieceTracker and PieceFlagged migrations (#1615) * fix: yugabyte migrate command name * Add miner address to top of page in boost UI (#1633) * feat: add miner address to top of page in boost UI * Update react/src/MinerAddress.js Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com> --------- Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com> * refactor: move StorageAccessApiInfo config into DealMaking at GraphsyncStorageAccessApiInfo (#1634) * Show list of retrieval miners on retrievals list page (#1637) * feat: show list of retrieval miners on retrievals list page * fix: retrieval miner address resolver * fix: mmlid fixes for LID UI (#1639) * fix: look up unseal status against multi-miner accessor (rather than just on local miner) (#1641) * Show warning on piece doctor page if still doing initial scan (#1643) * fix: look up unseal status against multi-miner accessor (rather than just on local miner) * feat: show warning on piece doctor page if still doing initial scan * Update extern/boostd-data/yugabyte/piecedoctor.go Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> * Update extern/boostd-data/yugabyte/piecedoctor.go --------- Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com> * feat: change postgres timezone type to include timezone (#1645) * feat: show network name in binary versions (#1642) * fix boostd-data maddr, enhance build * add CQL migrator * refactor migrator * modify migrate query * remove idx from migrate query * remove CQL migrator * undo go mod changes, fix mainnet build * undo yugabyte changes * remove extra line * Cassandra migrations (#1648) * feat: cassandra migrations * refactor: dbname -> appliedMigration * fix: yugabyte lid test * feat: add postgres migration * refactor: simplify cassandra migrations * fix: delete duplicate rows in PieceTracker table * fix test --------- Co-authored-by: dirkmc <dirkmdev@gmail.com> Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1640
TODO: