fix(docker): no inline sed commands
#1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sed commands output seperate files and then copy over. see: https://forums.docker.com/t/sed-couldnt-open-temporary-file-xyz-permission-denied-when-using-virtiofs/125473/5
hannahhoward
changed the title
sed commandssed commands
willscott
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Fix an issue encountered using
sedin the devnet with Docker Desktop for Mac.Implemention
When I tried to run devnet on my machine with Docker Desktop For Mac, I encountered an error where the boost container would shutdown while trying to run
sedcommands to update it's config, due to a permission error.I tracked this down to https://forums.docker.com/t/sed-couldnt-open-temporary-file-xyz-permission-denied-when-using-virtiofs/125473/5 and was able to fix it by making
sednot running inline.For Discussion
Possible alternate approach: Farther down the thread there's a suggestion the problem is fixed in
sed4.8, but that would require updating Ubuntu to 22 in the runner.