Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make Boost curio compliant #1918

Merged
merged 10 commits into from
Jun 13, 2024
Merged

feat: make Boost curio compliant #1918

merged 10 commits into from
Jun 13, 2024

Conversation

LexLuthr
Copy link
Collaborator

@LexLuthr LexLuthr commented May 15, 2024

DO NOT MERGE THIS

This PR will act as testbed till we have Curio GA.

./boost provider libp2p-info t01004
Provider: t01004
Agent: boost-curio-2.2.0+debug+git.a209228.dirty
Peer ID: 12D3KooWBykrwMScKZYjiSBPDZQAjhZhLH5ccGT3ozauR4P1JiAD
Peer Addresses:
  /ip4/127.0.0.1/tcp/24001
Protocols:
  /fil/datatransfer/1.2.0
  /fil/retrieval/qry/1.0.0
  /fil/retrieval/transports/1.0.0
  /fil/storage/ask/1.0.1
  /fil/storage/ask/1.1.0
  /fil/storage/mk/1.0.1
  /fil/storage/mk/1.1.0
  /fil/storage/mk/1.1.1
  /fil/storage/mk/1.2.0
  /fil/storage/mk/1.2.1
  /fil/storage/status/1.2.0
  /floodsub/1.0.0
  /http/1.1
  /ipfs/graphsync/1.0.0
  /ipfs/graphsync/2.0.0
  /ipfs/id/1.0.0
  /ipfs/id/push/1.0.0
  /ipfs/ping/1.0.0
  /libp2p/autonat/1.0.0
  /libp2p/balancer/forwarding/0.0.1
  /meshsub/1.0.0
  /meshsub/1.1.0
Screenshot 2024-05-15 at 7 20 43 PM Screenshot 2024-05-15 at 7 26 36 PM Screenshot 2024-05-15 at 11 37 51 PM

@LexLuthr LexLuthr mentioned this pull request May 15, 2024
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, looks good generally

node/config/types.go Outdated Show resolved Hide resolved
storagemarket/deal_execution.go Show resolved Hide resolved
node/config/def.go Outdated Show resolved Hide resolved
node/modules/lp2p.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaict the Curio config can now be dropped, also make gen complains. Other than that looks good!

node/config/types.go Outdated Show resolved Hide resolved
@LexLuthr
Copy link
Collaborator Author

@magik6k "UserAgent" gets invoked but it is not run by fx. I am not sure why.

lexluthr@Lexs-Mac boost % ./boost provider libp2p-info t01002
Provider: t01002
Agent: lotus-1.27.1-dev+debug
Peer ID: 12D3KooWMXExSnZHMbWraVeFjPNCwZHUKVXvU5H3DTp1jNd9dAmP
Peer Addresses:
  /ip4/127.0.0.1/tcp/24001

node/builder.go Outdated Show resolved Hide resolved
node/modules/lp2p.go Outdated Show resolved Hide resolved
@LexLuthr
Copy link
Collaborator Author

Curio indicator

Screenshot 2024-06-11 at 4 56 38 PM

@LexLuthr LexLuthr merged commit eec2c07 into main Jun 13, 2024
21 checks passed
@LexLuthr LexLuthr deleted the feat/curio branch June 13, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants