feat: Curio support #1914
Closed
feat: Curio support #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/init-lp-support
branch
from
ca0b4b5
to
94ec60d
Compare
LexLuthr
requested changes
Apr 30, 2024
| @@ -167,3 +179,158 @@ func NewPieceDoctor(cfg *config.Boost) func(lc fx.Lifecycle, maddr lotus_dtypes. | |||
| return doc | |||
| } | |||
| } | |||
|
|
|||
| type boostPieceStoreWrapper struct { | |||
There was a problem hiding this comment.
Why do we need this wrapper in Boost?
| return fmt.Errorf("getting reader over piece %s: %w", pieceCid, err) | ||
| var reader types.SectionReader | ||
|
|
||
| reader, err := os.OpenFile(inFile, os.O_RDONLY, 0) |
There was a problem hiding this comment.
This will result in incorrect offset for CIDs. We read from pieceReader because we need exact location in the unsealed copy to get the data back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements some things needed for Curio to talk to boost; Not sure how I managed to not PR this before.