[Project Submission] LetherWallet #290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfeiWan9
reviewed
Sep 24, 2021
| <!--Describe who will be your project's users--> | ||
|
|
||
| ## Rough estimated user base (if applicable) | ||
| about 5 miner shareholders |
| <!--Attach a link to your GitHub repo if it's OSS--> | ||
|
|
||
| ## Website | ||
| https://github.com/joyceqingling/lotus-offchain-wallet |
There was a problem hiding this comment.
Do you already have a website for this application?
- if yes, please update the link.
- if not, please just leave it blank.
|
|
||
| ## Docs | ||
| https://github.com/slate-engineering/wallet | ||
| <!--Including a link to your project docs!--> |
There was a problem hiding this comment.
This is a repo link to ARG repo, not related to your project. Can you please update it ?
| <!--Including a link to your project docs!--> | ||
|
|
||
| ## Team Info | ||
| People at Protocol Labs build protocols, tools, and services to radically improve the Internet. The Applications Research Group (ARG) is an auxiliary team that aims to bolsters the mission by focusing on shipping tools that people love to use on the Internet. -- more at https://arg.protocol.ai |
There was a problem hiding this comment.
I assume this part is forgotten to be updated since this project is initialized by neither PL nor ARG. Can you please fix it and use the right intro of your team.
|
|
||
| ## How the community can engage | ||
| Email: joyceshiling@gmail.com | ||
| Slack: Joyce |
There was a problem hiding this comment.
Suggested change
| Slack: Joyce | |
| Slack: Joyce |
| Joyce Hu | ||
|
|
||
| ## How the community can engage | ||
| Email: joyceshiling@gmail.com |
There was a problem hiding this comment.
Suggested change
| Email: joyceshiling@gmail.com | |
| Email: joyceshiling@gmail.com |
|
Thank you for your project submission. I have reviewed it and left a few comments, could you please update it accordingly ? @joyceqingling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.