Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup channel monitor when a channel is restarted #269

Merged
merged 1 commit into from Oct 14, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Oct 14, 2021

Fixes #268

@codecov-commenter
Copy link

Codecov Report

Merging #269 (4707684) into master (3260d19) will increase coverage by 0.06%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   67.77%   67.83%   +0.06%     
==========================================
  Files          24       24              
  Lines        3131     3137       +6     
==========================================
+ Hits         2122     2128       +6     
- Misses        649      650       +1     
+ Partials      360      359       -1     
Impacted Files Coverage Δ
impl/restart.go 61.79% <33.33%> (-2.06%) ⬇️
network/libp2p_impl.go 67.53% <0.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3260d19...4707684. Read the comment docs.

Copy link
Collaborator

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dirkmc dirkmc merged commit 3dfabfd into master Oct 14, 2021
@dirkmc dirkmc deleted the fix/chanmon-restart branch October 14, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants