Demonstrate no monitoring after restart #268
Conversation
| RestartDebounce: time.Second * 10, | ||
| RestartBackoff: time.Second * 20, | ||
| MaxConsecutiveRestarts: 15, | ||
| //RestartAckTimeout: time.Second * 30, |
There was a problem hiding this comment.
Seems like this shouldn't be here, it's not in Config type. Is it a TODO for future work?
The OnRestartComplete below could probably be removed too since it's not being used, or is that another TODO?
| @@ -118,6 +132,11 @@ func TestRestartPush(t *testing.T) { | |||
| if event.Code == datatransfer.DataSent { | |||
| if channelState.Sent() > 0 { | |||
| sent <- channelState.Sent() | |||
| if rh.dt1.IsChannelMonitored(chid) { | |||
There was a problem hiding this comment.
is there something we could do here to collect state and assert on it later?
Track monitoredCount unmonitoredCount and assert they're above some base number?
|
The reason that the monitor appears to stop monitoring the channel after a restart in this test is because after restart, the test swaps out the existing data transfer instance for a new one: The new data transfer instance has a new channel monitor instance, so it has no knowledge of the old channel monitor's channels. In any case the overall concept is correct - we should start the channel monitor when RestartDataTransferChannel is called. |
What
When a new instance of go-data-transfer is constructed, and RestartDataTransferChannel is called, no channel monitoring is setup, meaning if the request stalls or errors, it will simply stay stalled.
Demonstration
This is a bit of a contrive example (contains some functions you probably don't want to expose the monitoring status to the public)
Essentially this PR:
Result: