VerifiedCar: remove extraneous go-routine #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## rvagg/http-validation #226 +/- ##
=========================================================
+ Coverage 71.08% 71.36% +0.27%
=========================================================
Files 65 65
Lines 5713 5685 -28
=========================================================
- Hits 4061 4057 -4
+ Misses 1432 1416 -16
+ Partials 220 212 -8
|
rvagg
reviewed
May 10, 2023
rvagg
approved these changes
May 10, 2023
hannahhoward
added a commit
that referenced
this pull request
May 11, 2023
* feat(verifiedcar): initial verifiedcar package * feat(verifiedcar): verify http retrievals * chore(verifiedcar): tests for basic error cases * fix(verifiedcar): coverage of more cases, handle known edges properly * fix(verifiedcar): remove extraneous go-routine (#226) Co-authored-by: Rod Vagg <rod@vagg.org> * fix(verifiedcar): address feedback * fix(verifiedcar): fix flaky tests --------- Co-authored-by: Hannah Howard <hannah@hannahhoward.net>
rvagg
added a commit
that referenced
this pull request
May 12, 2023
* feat(verifiedcar): initial verifiedcar package * feat(verifiedcar): verify http retrievals * chore(verifiedcar): tests for basic error cases * fix(verifiedcar): coverage of more cases, handle known edges properly * fix(verifiedcar): remove extraneous go-routine (#226) Co-authored-by: Rod Vagg <rod@vagg.org> * fix(verifiedcar): address feedback * fix(verifiedcar): fix flaky tests --------- Co-authored-by: Hannah Howard <hannah@hannahhoward.net>
hannahhoward
added a commit
that referenced
this pull request
May 12, 2023
* First pass at adapting graphsync to http * fix(http): gracefully handle selector vs path requests * feat(http): extend graphsyncretriever so it can also do http * feat(http): refactor http & graphsync specific pieces to "TransportProtocol" iface * feat(prioritywaitqueue): add InitialPauseDone inspector * feat(http): single peer http retrieval unit test * fix(http): enable http everywhere gs & bs are * chore(http): framework for suite of http unit tests based on bitswap unit test framework * feat(http): remove parallel-request flow, make all serial for now * too-detailed http testing, will remove this in favour of graphsync style testing. * fix(http): better testing framework * fix(http): more test coverage, minor fixes * fix(http): clean up time handling in tests * HTTP CAR validation (#222) * feat(verifiedcar): initial verifiedcar package * feat(verifiedcar): verify http retrievals * chore(verifiedcar): tests for basic error cases * fix(verifiedcar): coverage of more cases, handle known edges properly * fix(verifiedcar): remove extraneous go-routine (#226) Co-authored-by: Rod Vagg <rod@vagg.org> * fix(verifiedcar): address feedback * fix(verifiedcar): fix flaky tests --------- Co-authored-by: Hannah Howard <hannah@hannahhoward.net> * fix(http): refactor MockRoundTripper (#229) * Add HTTP integegration tests (#227) * test: add itests for http * test: add peer http server, minor refactors and fixes * fix(itest): fix compile errors on rebase --------- Co-authored-by: Rod Vagg <rod@vagg.org> Co-authored-by: Hannah Howard <hannah@hannahhoward.net> Co-authored-by: Kyle Huntsman <3432646+kylehuntsman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
I was going to leave feedback about an extraneous go routine in verified car but I wanted to see if it worked first. It certainly appears to.