Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test alternate fix for bitswap #391

Closed
wants to merge 21 commits into from

Conversation

hannahhoward
Copy link
Collaborator

Mostly want to see if my fix for bitswap ipfs/boxo#452 fixes our issue

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #391 (93080a2) into rvagg/byte-range-proper (c40fe59) will increase coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           rvagg/byte-range-proper     #391      +/-   ##
===========================================================
+ Coverage                    77.12%   77.26%   +0.13%     
===========================================================
  Files                           87       87              
  Lines                         6611     6611              
===========================================================
+ Hits                          5099     5108       +9     
+ Misses                        1246     1241       -5     
+ Partials                       266      262       -4     

see 7 files with indirect coverage changes

@rvagg
Copy link
Member

rvagg commented Aug 24, 2023

http: unexpected EOF reading trailer, and on windows, this is different and not the normal failure for bitswap problems - failure mode is usually not receiving anything, this indicates the server is trying to send an error (it also doesn't normally error on windows); strange

@rvagg rvagg force-pushed the rvagg/byte-range-proper branch 2 times, most recently from ba2f0b7 to 08d6372 Compare August 24, 2023 06:32
Base automatically changed from rvagg/byte-range-proper to main August 24, 2023 07:15
@rvagg rvagg closed this Sep 6, 2023
@rvagg rvagg deleted the rvagg/byte-range-proper-alternate-fix branch September 6, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants