chore: post Go 1.19 multi-error cleanup #453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a result of checking the errors list with "Other" taking up a very large share, we have, in places 2 and 3:
tbh I'm not actually sure why the former is now showing up more than the latter, I suspect it must have been something I did with the context juggling I've had to do
We're also getting this now:
Which is fine, but I think it would be preferable to show this as a timeout instead (i.e. parent retrieval has a timeout and cancels context, the protocol retriever records it as a context cancel). It may be possible to use
WithCancelCause
to check forDeadlineExceeded
post 1.19, but this'll need some investigation.